[pull] main from pytest-dev:main#116
Merged
Merged
Conversation
The function name is ambiguous, full nodeid is more helpful.
Needed for the next commit.
…ect=[...]` The code in `_get_direct_parametrize_args` only handled `indirect=True/False`, it didn't account for `indirect=[...]`. This caused the added test to start failing after d56b1af. Fix by using the common `_resolve_args_directness` function. It's a bit heavy for the task but correctness first... Fix #13974.
fixtures: fix incorrect "duplicate parametrization" when using `indirect=[...]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Fix incorrect duplicate parametrization detection when using indirect=[...] and improve error messages by using the full nodeid instead of function names.
Bug Fixes
Refactors
Written for commit 6b6502e. Summary will update automatically on new commits.