Conversation
wg102
requested changes
Jul 16, 2021
There was a problem hiding this comment.
Quite nice, I have a few things and then general comments. Some comments happen more than once.
- -> how do those work for i18n? Do they also have keys? How are changed in the string handled? etc
- Possibly using plural in a standard form
I did not look at the few French translation spelling.
Comment on lines
+43
to
+110
| const resources = { | ||
| en: { | ||
| accounts: enAccounts, | ||
| bucketsDetails: enBucketDetails, | ||
| listBuckets: enListBuckets, | ||
| common: enCommon, | ||
| configurations: enConfigurations, | ||
| dashboard: enDashboard, | ||
| directCSI: enDirectCSI, | ||
| groups: enGroups, | ||
| heal: enHeal, | ||
| healthInfo: enHealthInfo, | ||
| license: enLicense, | ||
| logs: enLogs, | ||
| menu: enMenu, | ||
| storage: enStorage, | ||
| tenants: enTenants, | ||
| trace: enTrace, | ||
| users: enUsers, | ||
| }, | ||
| fr: { | ||
| accounts: frAccounts, | ||
| bucketsDetails: frBucketDetails, | ||
| listBuckets: frListBuckets, | ||
| common: frCommon, | ||
| configurations: frConfigurations, | ||
| dashboard: frDashboard, | ||
| directCSI: frDirectCSI, | ||
| groups: frGroups, | ||
| heal: frHeal, | ||
| healthInfo: frHealthInfo, | ||
| license: frLicense, | ||
| logs: frLogs, | ||
| menu: frMenu, | ||
| storage: frStorage, | ||
| tenants: frTenants, | ||
| trace: frTrace, | ||
| users: frUsers, | ||
| } | ||
| }; |
There was a problem hiding this comment.
Is there another way to handle this? It seems strange
Nancy-Badran
requested changes
Jul 21, 2021
jumana-s
force-pushed
the
add-i18n-
branch
4 times, most recently
from
1d4e99c to
14ed5f6
Compare
jumana-s
force-pushed
the
add-i18n-
branch
3 times, most recently
from
a787168 to
7705467
Compare
jumana-s
force-pushed
the
add-i18n-
branch
2 times, most recently
from
eeb5339 to
0945562
Compare
jumana-s
force-pushed
the
add-i18n-
branch
2 times, most recently
from
7b6367e to
202f8b9
Compare
wg102
reviewed
Sep 7, 2021
wg102
left a comment
wg102
left a comment
There was a problem hiding this comment.
The code looks pretty neat. I would maybe update or add a Readme for details on how to 'keep the i18n updated'. Including when/how to use the get-errors.sh script and what its purpose is. Things like that to help future contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.