Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the API client to version 1.2.6, incorporating the latest specifications from the National Assembly Open API. The changes ensure the client remains current with the external API, involving a refresh of the master list, new and updated API specifications, and the subsequent regeneration of Python models and enums to support these changes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the API client to version 1.2.6, reflecting the latest specifications from the National Assembly Open API. The changes primarily involve regenerating models and enums based on the new specs and adding corresponding test fixtures. My review has identified a significant breaking change in the Service enum that could impact users of the library. I have also noted a minor stylistic issue across the newly added test fixture files. Please see the detailed comments for suggestions.
| 의안_접수목록 = "OOWY4R001216HX11537" | ||
| 의안_접수목록_OOWY4R001216HX11458 = "OOWY4R001216HX11458" | ||
| 의안_제안자정보 = "OOWY4R001216HX11460" | ||
| 의안별_표결현황 = "OND1KZ0009677M13515" | ||
| 의안별_회의록_목록 = "OOWY4R001216HX11526" | ||
| 의안정보_통합_API = "OOWY4R001216HX11440" | ||
| 의안정보_통합_API = "OOWY4R001216HX11536" | ||
| 의안정보_통합_API_OOWY4R001216HX11440 = "OOWY4R001216HX11440" |
There was a problem hiding this comment.
The values for Service.의안_접수목록 and Service.의안정보_통합_API have been changed to point to new service IDs. This is a breaking change for users of the library, as their code relying on these enum members will now call different API endpoints unexpectedly.
While the old service IDs are preserved in new enum members with suffixes (e.g., 의안_접수목록_OOWY4R001216HX11458), changing the value of an existing public enum member violates semantic versioning principles for a minor version bump and can lead to subtle bugs in consumer code.
To maintain backward compatibility, I suggest keeping the original enum members pointing to their old service IDs and introducing new members for the new services. For example:
의안_접수목록 = "OOWY4R001216HX11458"
의안_접수목록_V2 = "OOWY4R001216HX11537" # Or a more descriptive name
...
의안정보_통합_API = "OOWY4R001216HX11440"
의안정보_통합_API_V2 = "OOWY4R001216HX11536"If the old endpoints are deprecated, it would be better to rename them to explicitly mark them as such (e.g., 의안_접수목록_DEPRECATED).
Since this file is auto-generated, this likely requires a change in the code generator. As a temporary measure for this PR, you could manually adjust this file to prevent this breaking change.
| ] | ||
| } | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file is missing a final newline character. It's a POSIX standard and a common convention to end text files with a newline. This can prevent issues with certain tools (like cat, wc) and diff viewers. This comment applies to all newly added JSON fixture files in this pull request.
StatPan
force-pushed
the
update-api-specs
branch
7 times, most recently
from
ac4a32f to
e54680a
Compare
StatPan
force-pushed
the
update-api-specs
branch
7 times, most recently
from
eab818a to
e053ec9
Compare
StatPan
force-pushed
the
update-api-specs
branch
4 times, most recently
from
b8927b1 to
bca7972
Compare
StatPan
changed the title
StatPan
force-pushed
the
update-api-specs
branch
7 times, most recently
from
beb24d7 to
625a17c
Compare
StatPan
force-pushed
the
update-api-specs
branch
2 times, most recently
from
b421901 to
24bc857
Compare
StatPan
force-pushed
the
update-api-specs
branch
7 times, most recently
from
e810e05 to
5f82ba0
Compare
StatPan
force-pushed
the
update-api-specs
branch
7 times, most recently
from
79ec0f1 to
8c98082
Compare
StatPan
force-pushed
the
update-api-specs
branch
from
8c98082 to
4e6c318
Compare
1 participant
This PR updates the API client with the latest specifications from the National Assembly Open API.