Skip to content

Fix K8S ServiceBinding Test#1109

Merged
TimHess merged 1 commit into
release/3.2from
backport_1108
Feb 21, 2023
Merged

Fix K8S ServiceBinding Test#1109
TimHess merged 1 commit into
release/3.2from
backport_1108

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Feb 16, 2023

Update ServiceBindingConfigurationSourceTest.cs

Description

Backport of #1108 to 3.2

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess
Merge pull request #1108 from SteeltoeOSS/Fix-K8S-ServiceBinding-Test
0a367df 
Update ServiceBindingConfigurationSourceTest.cs
@TimHess TimHess added Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Feb 16, 2023
@TimHess TimHess self-assigned this Feb 16, 2023
@TimHess TimHess requested review from dtillman and hananiel February 16, 2023 19:07
@TimHess
Copy link
Copy Markdown
Member Author

TimHess commented Feb 16, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Feb 16, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hananiel
hananiel approved these changes Feb 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimHess TimHess merged commit 1a9cc52 into release/3.2 Feb 21, 2023
@TimHess TimHess deleted the backport_1108 branch February 21, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtillman dtillman Awaiting requested review from dtillman

1 more reviewer

@hananiel hananiel hananiel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TimHess TimHess

Labels

Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimHess @hananiel