Skip to content

Allow return of empty string values through placeholder resolver (4.0)#1135

Merged
TimHess merged 1 commit into
mainfrom
placeholder_empty
Jun 14, 2023
Merged

Allow return of empty string values through placeholder resolver (4.0)#1135
TimHess merged 1 commit into
mainfrom
placeholder_empty

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Jun 13, 2023

Description

Patch to return the expected empty string instead of null when placeholder resolver is used

addresses #1132 in 4.0 (replay of #1133)

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Component/Configuration Issues related to Configuration providers ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jun 13, 2023
@TimHess TimHess added this to the 4.0.0-m1 milestone Jun 13, 2023
@TimHess TimHess requested review from bart-vmware and hananiel June 13, 2023 19:27
@TimHess TimHess self-assigned this Jun 13, 2023
@TimHess TimHess changed the title allow return of empty string values through placeholder resolver Allow return of empty string values through placeholder resolver (4.0) Jun 13, 2023
@TimHess TimHess force-pushed the placeholder_empty branch from abb34d1 to 41e9fbc Compare June 14, 2023 14:25
Copy link
Copy Markdown
Contributor

@ccheetham ccheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TimHess TimHess merged commit 16a4b3a into main Jun 14, 2023
@TimHess TimHess deleted the placeholder_empty branch June 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Configuration Issues related to Configuration providers ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants