Skip to content

Fix type checking for IHttpClientHandlerProvider in Eureka client#1141

Merged
TimHess merged 1 commit into
release/3.2from
bug/httpclienthandlerprovider
Jul 11, 2023
Merged

Fix type checking for IHttpClientHandlerProvider in Eureka client#1141
TimHess merged 1 commit into
release/3.2from
bug/httpclienthandlerprovider

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Jul 10, 2023

Description

Use IsAssignableFrom instead of is operator, get IHttpClientHandlerProvider from the service collection at runtime
Addresses #1137 in Steeltoe 3.2

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Discovery Issues related to Steeltoe Service Discovery labels Jul 10, 2023
@TimHess TimHess added this to the 3.2.4 milestone Jul 10, 2023
@TimHess TimHess requested review from bart-vmware and hananiel July 10, 2023 21:03
@TimHess TimHess self-assigned this Jul 10, 2023
@TimHess
Copy link
Copy Markdown
Member Author

TimHess commented Jul 10, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess merged commit f15d4e9 into release/3.2 Jul 11, 2023
@TimHess TimHess deleted the bug/httpclienthandlerprovider branch July 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants