Skip to content

Limit failing listener to a configured MaxAttempts#1168

Merged
hananiel merged 8 commits into
mainfrom
MaxRetries_FailingListener
Oct 3, 2023
Merged

Limit failing listener to a configured MaxAttempts#1168
hananiel merged 8 commits into
mainfrom
MaxRetries_FailingListener

Conversation

@hananiel
Copy link
Copy Markdown
Contributor

@hananiel hananiel commented Aug 29, 2023

Description

Currently the RabbitMQ container configured by the RabbitListener does not respect the configured MaxAttempts value. Adding the required PollyRetry and callback as requested by the configuration.

Fixes #1164

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@hananiel hananiel self-assigned this Aug 29, 2023
@hananiel hananiel force-pushed the MaxRetries_FailingListener branch from af11c84 to 625e5b1 Compare October 2, 2023 18:53
@hananiel hananiel force-pushed the MaxRetries_FailingListener branch from 625e5b1 to 1f587b7 Compare October 2, 2023 18:54
@hananiel hananiel marked this pull request as ready for review October 2, 2023 18:57
@hananiel hananiel added this to the 4.0.0-m1 milestone Oct 2, 2023
@hananiel
Copy link
Copy Markdown
Contributor Author

hananiel commented Oct 2, 2023

I will backport to 3.x once approved.

@TimHess TimHess added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Oct 2, 2023
Co-authored-by: Tim Hess <thess@vmware.com>
@hananiel
Copy link
Copy Markdown
Contributor Author

hananiel commented Oct 2, 2023

/azp run cleanup-code

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Code cleanup successfully reformatted files and pushed changes.

Copy link
Copy Markdown
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hananiel hananiel merged commit dad2e48 into main Oct 3, 2023
@hananiel hananiel deleted the MaxRetries_FailingListener branch October 3, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Messaging ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How can you limit retries on exception when using RabbitListener?

2 participants