Skip to content

Consul - Add support for metadata in a backwards compatible way#1180

Merged
hananiel merged 6 commits into
SteeltoeOSS:release/3.2from
cieciurm:feature/consul-add-tags-as-metadata
Sep 18, 2023
Merged

Consul - Add support for metadata in a backwards compatible way#1180
hananiel merged 6 commits into
SteeltoeOSS:release/3.2from
cieciurm:feature/consul-add-tags-as-metadata

Conversation

@cieciurm
Copy link
Copy Markdown
Contributor

@cieciurm cieciurm commented Sep 10, 2023

Description

This PR backports #1167 to 3.x

I'd like to open a discussion on some details regarding implementation before completing it and adding tests.

I tried to get some inspiration from Spring Cloud Consul implementation:

  • Added TagsAsMetadata (defaults to true)
  • This setting controls whether we fallback to Metadata creation from Tags (default) or we use the real Metadata
  • Both approaches add default metadata

Let me know if this is what you had in mind. I will add unit tests then.
Documentation changes will follow.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/enhancement New feature or request ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Discovery Issues related to Steeltoe Service Discovery labels Sep 14, 2023
@TimHess TimHess added this to the 3.2.5 milestone Sep 14, 2023
@cieciurm cieciurm changed the title [wip] Consul - Add support for metadata in a backwards compatible way Consul - Add support for metadata in a backwards compatible way Sep 14, 2023
@cieciurm
Copy link
Copy Markdown
Contributor Author

cieciurm commented Sep 14, 2023

Tests added, ready for review 👨🏽‍🔬.

cc @hananiel

Copy link
Copy Markdown
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM.

@TimHess
Copy link
Copy Markdown
Member

TimHess commented Sep 18, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@hananiel hananiel merged commit b779737 into SteeltoeOSS:release/3.2 Sep 18, 2023
@cieciurm
Copy link
Copy Markdown
Contributor Author

Thanks @hananiel!

I will update docs in 2 weeks time, when I'm back from my vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants