Skip to content

Handle trailing semicolon in address list#1189

Merged
TimHess merged 3 commits into
release/3.2from
bug/null_url
Oct 2, 2023
Merged

Handle trailing semicolon in address list#1189
TimHess merged 3 commits into
release/3.2from
bug/null_url

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Sep 29, 2023

Addresses #1186 in 3.2

@TimHess TimHess self-assigned this Sep 29, 2023
@TimHess TimHess requested a review from hananiel September 29, 2023 16:47
@TimHess TimHess added Type/bug Something isn't working ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Discovery Issues related to Steeltoe Service Discovery labels Sep 29, 2023
@TimHess TimHess added this to the 3.2.5 milestone Sep 29, 2023
@TimHess
Copy link
Copy Markdown
Member Author

TimHess commented Sep 29, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/Discovery/src/ClientBase/ConfigurationUrlHelpers.cs Outdated
Comment thread src/Discovery/test/ClientBase.Test/ConfigurationUrlHelpers.cs
Copy link
Copy Markdown
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess merged commit fbc8cfe into release/3.2 Oct 2, 2023
@TimHess TimHess deleted the bug/null_url branch October 2, 2023 15:36
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants