Enhancements for Spring Boot Admin registration#1508
Merged
Conversation
3f6aef6 to
3deac4d
Compare
a26cbda to
6ad31f9
Compare
6ad31f9 to
7be2a50
Compare
73ab642 to
624da32
Compare
This was referenced Apr 22, 2025
…gured HttpClient.Timeout of 0.5 seconds elapsing."
afb96e5 to
07181a4
Compare
TimHess
reviewed
Apr 22, 2025
TimHess
reviewed
Apr 22, 2025
Co-authored-by: Tim Hess <tim.hess@broadcom.com>
TimHess
reviewed
Apr 23, 2025
Member
Author
|
The Config Server flaky test fix is based on the following log fragment: The new diagnostics are starting to prove helpful. A 10 ms timeout is way too short, so I changed it to 1 sec. The other test is supposed to trigger a timeout, so it can be shortened. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR enhances the registration process of Steeltoe apps with a Spring Boot Admin server.
User-Agentheader of outbound HTTP requestsBreaking changes:
BasePathconfiguration key was renamed toBaseUrl(new keyBasePathmeans something else)ConnectionTimeoutMssetting reduced to 5 secondsFixes #490
Quality checklist
Documentation PR: Update documentation for Spring Boot Admin registration Documentation#371
Samples PR: Update sample for Spring Boot Admin registration Samples#387