Async refactorings

[bart-vmware]

Description

Reviewed the Steeltoe codebase against the guidance at https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md.

We can't apply all of the guidance because there's simply no async call stack in Configuration. So we're stuck with sync-over-async there. That unnecessarily blocks a thread, but fortunately doesn't deadlock in ASP.NET Core. Our async-void cases catch all exceptions, so it won't crash the process. What remains are quite some violations in DotNetHeapDump, but changing that is very high risk, so I didn't bother.

We have some violations that only appear in tests, resulting in potential memory leaks, but that's not too important, and there is no easy fix.

Closes #1475.

Quality checklist

• Your code complies with our Coding Style.
• You've updated unit and/or integration tests for your change, where applicable.
• You've updated documentation for your change, where applicable.
  If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
• You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

[Copilot]

Pull Request Overview

This PR refactors asynchronous code related to thread dumping and dynamic task result retrieval within the Steeltoe codebase.

• Refactored timeout handling logic in EventPipeThreadDumper to use a dedicated CancellationTokenSource.
• Replaced the direct Result property access with a new GetResult() method in TaskShim and its call sites across multiple connector shims.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Management/src/Endpoint/Actuators/ThreadDump/EventPipeThreadDumper.cs	Refactored async timeout logic to use an internal CancellationTokenSource and CancelAsync for cleaning up the Task.Delay timer.
src/Connectors/src/Connectors/Redis/DynamicTypeAccess/DatabaseInterfaceShim.cs	Updated to use GetResult() for retrieving the task result instead of accessing Result directly.
src/Connectors/src/Connectors/Redis/DynamicTypeAccess/ConnectionMultiplexerShim.cs	Similar change applied: using GetResult() to retrieve the task result for consistent behavior.
src/Connectors/src/Connectors/RabbitMQ/DynamicTypeAccess/ConnectionFactoryInterfaceShim.cs	Updated retrieval of task result via GetResult() ensuring consistency.
src/Connectors/src/Connectors/MongoDb/DynamicTypeAccess/MongoClientInterfaceShim.cs	Consistent update using GetResult() for better clarity in async result extraction.
src/Common/src/Common/DynamicTypeAccess/TaskShim.cs	Replaced the Result property with a GetResult() method, impacting multiple shim files for consistency.

Comments suppressed due to low confidence (3)

src/Management/src/Endpoint/Actuators/ThreadDump/EventPipeThreadDumper.cs:443

• Ensure that CancelAsync() is a valid and well-documented extension method in this codebase, as it is not part of the standard .NET API. Consider using the standard Cancel() method if a custom async cancel behavior is not required.

await timeoutSource.CancelAsync();

src/Common/src/Common/DynamicTypeAccess/TaskShim.cs:26

• [nitpick] The refactor replacing the 'Result' property with the GetResult() method improves clarity; ensure that its exception handling and performance characteristics match the previous behavior.

public TResult GetResult()

src/Connectors/src/Connectors/Redis/DynamicTypeAccess/DatabaseInterfaceShim.cs:20

• [nitpick] Updating to GetResult() enhances consistency across dynamic shims; verify that all similar usages have been updated to prevent potential runtime discrepancies.

return taskShim.GetResult();

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud