Add Support for Google Analytics V4 gtag#162
Merged
StefMa merged 1 commit intoStefMa:masterfrom Mar 14, 2023
Merged
Conversation
StefMa
requested changes
Mar 14, 2023
Owner
StefMa
left a comment
StefMa
left a comment
There was a problem hiding this comment.
Nice catch 👍
Thank you for the contribution.
Can you please change the go.mod file? Then I can merge it 🙂 Thank you!
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/StefMa/hugo-fresh | |||
| module github.com/selkhateeb/hugo-fresh | |||
Owner
There was a problem hiding this comment.
This should be reverted 😇
Suggested change
| module github.com/selkhateeb/hugo-fresh | |
| module github.com/StefMa/hugo-fresh |
Owner
|
Maybe you can also adjust the Would be nice I guess 🙃 |
According to Hugo's documentation (https://gohugo.io/templates/internal/#use-the-google-analytics-template) This template is not suitable for Google Analytics 4 {{ template "_internal/google_analytics_async.html" . }} So, this change uses the recommended template that supports both versions.
Contributor
Author
|
Thanks @StefMa for your work on this and providing it. I've updated the branch and removed my testing nonsense. Also added the G-XXX comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Hugo's documentation (https://gohugo.io/templates/internal/#use-the-google-analytics-template)
This template is not suitable for Google Analytics 4 {{ template "_internal/google_analytics_async.html" . }}
So, this change uses the recommended template that supports both versions.