Remove leading slash for image paths#203
Merged
StefMa merged 2 commits intoStefMa:masterfrom May 1, 2024
Merged
Conversation
…mage file path handling
StefMa
approved these changes
May 1, 2024
Owner
StefMa
left a comment
StefMa
left a comment
There was a problem hiding this comment.
Wow, nice catch! Thanks for this 🙏
The test page still looks good
https://hugo-fresh-unstableunicorn-fix-leading-slash-for-image-paths.vercel.app/
Let's ship it!
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #202
Removed leading
/on image paths, deployments to sites on subpaths now work correctly.This was noticed when deploying to gitlab pages the images would not load, gitlab pages uses the following path convention:
Updated comments in example hugo.yaml to now be consistent with updates to paths.