[codex] fix: ignore stale shell reducer events#15
Merged
StiensWout merged 1 commit intoJun 22, 2026
Conversation
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyShellStreamEventagainst stale or equal sequence events before applying shell deltas.Root cause
The reducer accepted any recognized shell stream event and wrote
snapshotSequence: event.sequence. Direct reducer callers could therefore apply replayed or out-of-order events, mutate projects or threads, and lower the snapshot sequence.Impact
Shared shell state now preserves the existing snapshot when an event sequence is not newer than the current snapshot, keeping replay protection inside the reducer invariant.
Validation
PATH="$HOME/.vite-plus/bin:$PATH" vp test packages/client-runtime/src/state/shellReducer.test.tsPATH="$HOME/.vite-plus/bin:$PATH" vp checkPATH="$HOME/.vite-plus/bin:$PATH" vp run typecheckvp checkreports the repository existing 20 unrelated lint warnings and no errors.