Env variables needed to configure

[knownasilya]

So I'm trying to get my github setup working, but I think I had my base url misconfigured before. So now I revoked the permissions and set the right base url, but it still looks for the localhost base for the github callback url.

Are there any ENV variables for this plugin, would love a list so we can add to the readme.

[niallo]

Yes, it needs to be configured with the correct oauth app id and oauth app
secret. See:
https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L59

You'll also need to set the server name of course!

On Thu, Oct 9, 2014 at 10:30 AM, Ilya Radchenko notifications@github.com
wrote:

So I'm trying to get my github setup working, but I think I had my base
url misconfigured before. So now I revoked the permissions and set the
right base url, but it still looks for the localhost base for the github
callback url.

Are there any ENV variables for this plugin, would love a list so we can
add to the readme.

—
Reply to this email directly or view it on GitHub
#22.

Niall O'Higgins
W: http://niallohiggins.com
E: n@niallo.me
T: @niallohiggins

[knownasilya]

@niallo what are the env vars for those? Is there some kind of standard?

[jaredly]

@knownasilya just updated the readme
https://github.com/Strider-CD/strider-github/blob/master/Readme.md

[knownasilya]

@jaredly thanks! What's 'uncluding' in the last sentence? Typo or on purpose?

[jaredly]

good catch :) I make up words all the time

[knownasilya]

Hum, another error:

Cannot GET /auth/github/callback?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch

When I click 'Add Github'

[knownasilya]

Ok I had plugin_github_hostname, changed to strider_github_hostname, and now get: http://localhost:3000/auth/github/callback?code=b0520655490c9ad1141d which is wrong..

[niallo]

You need to set both host name parameters. I always thought the github
plugin should just use the main one but such is life :-/

On Thu, Oct 9, 2014 at 10:45 AM, Ilya Radchenko notifications@github.com
wrote:

Ok I had plugin_github_hostname, changed to strider_github_hostname, and
now get:
http://localhost:3000/auth/github/callback?code=b0520655490c9ad1141d
which is wrong..

—
Reply to this email directly or view it on GitHub
#22 (comment)
.

Niall O'Higgins
W: http://niallohiggins.com
E: n@niallo.me
T: @niallohiggins

[knownasilya]

@niallo so strider_github_hostname AND plugin_github_hostname?

So with both set, it goes here:

http://localhost:3000/auth/github/callback?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch

[jaredly]

no that's strider_hostname.
@niallo I'm not opposed to that, and I can't think of a reason not to change it

[knownasilya]

Maybe cause I'm doing all caps? Were they changed to lowercase?

[knownasilya]

Maybe the plugin never receives a config? https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L9