Skip to content

chore: update vulnerable dependencies#607

Merged
nicholasjjlim merged 1 commit into
mainfrom
fix/update-vulnerable-deps
Jul 1, 2026
Merged

chore: update vulnerable dependencies#607
nicholasjjlim merged 1 commit into
mainfrom
fix/update-vulnerable-deps

Conversation

@nicholasjjlim

@nicholasjjlim nicholasjjlim commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

🚀 Summary

Resolves all 20 Dependabot advisories on main (4 high, 12 moderate, 4 low).

Investigation showed most failures were a stale lockfile, not missing overrides: a fresh pnpm resolution — bounded by the existing minimumReleaseAge: 10080 (7-day) cooldown in pnpm-workspace.yaml — lands on patched, ≥7-day-old versions on its own. So this PR fixes the advisories with the minimum blast radius and prunes stale overrides.

✏️ Changes

Direct dependency bumps

  • vite ^7.3.2^7.3.5server.fs.deny bypass (HIGH); launch-editor NTLMv2 disclosure (MOD). Cooldown correctly holds it at aged 7.3.5, not the too-fresh 7.3.6.
  • dompurify ^3.4.0^3.4.11 — multiple IN_PLACE / hook & config-pollution XSS bypasses

Fixed by fresh resolution alone (no override needed — verified with pnpm why)

  • @grpc/grpc-js1.14.4 (HIGH×2) · weaviate-client > nice-grpc
  • hono4.12.27 (HIGH + MOD) · prisma > @prisma/dev > @hono/node-server
  • protobufjs7.6.4 (MOD) · @valkey/valkey-glide, @grpc/proto-loader
  • js-yaml4.2.0 (MOD) · eslint > @eslint/eslintrc

Override retained (genuinely load-bearing)

  • esbuild ^0.28.1 — dev-server arbitrary file read (LOW). tsx and vite both cap esbuild at 0.25.x, so an override is the only way to reach the patch.

🧹 Stale-override cleanup

Ran the skill's Step 7 check (remove → reinstall → re-audit) across all overrides. Overrides went 12 → 5. Removed 10 that natural resolution now satisfies unaided:

hono, protobufjs, @grpc/grpc-js, js-yaml, fast-xml-builder (was a no-op — not in the tree), fast-uri, devalue, postcss, ws, minimatch>brace-expansion.

Kept the 5 that each reintroduce an advisory when removed: @hono/node-server (>=1.19.13), fast-xml-parser, esbuild, cookie, exceljs>uuid.

✅ Verification

  • pnpm audit0 vulnerabilities (was 4 high / 12 moderate / 4 low)
  • Confirmed each removed override still resolves to a patched version via pnpm why
  • pnpm check → 0 errors, 0 warnings
  • pnpm test run361 tests pass (43 files)

🤖 Generated with aif-update-npm-dependencies

@nicholasjjlim nicholasjjlim added the skill:aif-update-npm-dependencies Opened with the aif-update-npm-dependencies skill label Jul 1, 2026
Resolve all 20 Dependabot advisories (4 high, 12 moderate, 4 low). Most were
stale-lockfile artifacts: a fresh pnpm resolution (bounded by the existing
minimumReleaseAge: 10080 cooldown) lands on patched, >=7-day-old versions
without needing overrides.

Direct dependency bumps:
- vite ^7.3.2 -> ^7.3.5 (fs.deny bypass; launch-editor NTLM leak)
- dompurify ^3.4.0 -> ^3.4.11 (multiple IN_PLACE / config-pollution XSS)

Fixed by fresh resolution alone (verified via pnpm why):
- @grpc/grpc-js -> 1.14.4  (weaviate-client>nice-grpc)
- hono -> 4.12.27          (prisma>@prisma/dev>@hono/node-server)
- protobufjs -> 7.6.4      (@valkey/valkey-glide, @grpc/proto-loader)
- js-yaml -> 4.2.0         (eslint>@eslint/eslintrc)

Override retained (genuinely load-bearing):
- esbuild ^0.28.1 (dev-server file read) - tsx and vite cap esbuild at 0.25.x

Stale-override cleanup: removed 10 overrides that natural resolution now
satisfies on its own (hono, protobufjs, @grpc/grpc-js, js-yaml, fast-xml-builder,
fast-uri, devalue, postcss, ws, minimatch>brace-expansion). Kept the 5 that are
still load-bearing: @hono/node-server, fast-xml-parser, esbuild, cookie,
exceljs>uuid (each reintroduces an advisory if removed).

Audit clean (0 vulnerabilities); svelte-check clean; 361 tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nicholasjjlim
nicholasjjlim force-pushed the fix/update-vulnerable-deps branch from 48f5ed2 to 2ee8898 Compare July 1, 2026 02:50
@nicholasjjlim
nicholasjjlim marked this pull request as ready for review July 1, 2026 02:56
@nicholasjjlim
nicholasjjlim requested a review from santosral July 1, 2026 02:56
@nicholasjjlim nicholasjjlim self-assigned this Jul 1, 2026
@nicholasjjlim
nicholasjjlim merged commit 3d1f10d into main Jul 1, 2026
8 checks passed
@nicholasjjlim
nicholasjjlim deleted the fix/update-vulnerable-deps branch July 1, 2026 02:59
@nicholasjjlim nicholasjjlim mentioned this pull request Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skill:aif-update-npm-dependencies Opened with the aif-update-npm-dependencies skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants