Wrap tray identicon in an ICO container so System.Drawing.Icon accepts it#16
Merged
Conversation
The new log surfaced the next exception in the chain: once H.NotifyIcon could read our PNG file (PR #15), it handed the bytes to new System.Drawing.Icon(stream, size) — which only accepts ICO-format input and throws ArgumentException on PNG. Modern Windows accepts a PNG payload embedded inside an ICO container: a 6-byte ICONDIR header plus a 16-byte ICONDIRENTRY pointing at the PNG bytes. WrapPngAsIco builds that header in-place; no native code, no extra dependencies, ~20 lines. The tray icon file changes extension from .png to .ico; pixels are unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArgumentException: Argument 'picture' must be a picture that can be used as a Icon.fromSystem.Drawing.Icon.Initialize, called byH.NotifyIcon.StreamExtensions.ToSmallIcon.new Icon(stream, size)only accepts ICO format — and we were writing raw PNG bytes..pngto.ico; pixels unchanged.Test plan
unhandled.log; right-click context menu works; left-click brings the window forward.🤖 Generated with Claude Code