Tags: show icon names, align card styling#44
Merged
Conversation
The icon text box now shows a picked glyph's friendly catalogue name (e.g. Settings) instead of a tofu box, falling back to its hex code point when the glyph isn't in the catalogue, and resolves a typed name back to its glyph. It commits on focus loss so the friendly form only replaces typed input once editing finishes. Tag cards now use the same background and 1px border as the Shared parameters, Trash and Settings cards (previously a borderless grey fill). ShellViewModel takes an optional IGlyphCatalogueProvider so the name lookup is available in production while unit tests stay unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-v0.1.0 polish to the Tags view.
Changes
Icon text box shows the friendly name, not a tofu box. A chosen glyph is now shown by its catalogue name (e.g.
Settings), falling back to its hex code point (e.g.E8EC) when the glyph isn't in the catalogue. You can also type a name (case-insensitive) and it resolves to the glyph, or type a code as before. The box commits on focus loss, so the friendly form only replaces typed input once editing finishes — never mid-keystroke.Card styling aligned. Tag cards now use the same
CardBackgroundFillColorDefaultBrush+ 1pxCardStrokeColorDefaultBrushborder (corner 8 / padding 16) as the Shared parameters and Trash cards. Previously they were a borderless grey fill (SubtleFillColorSecondaryBrush), which stood out in Light theme. Trash already matched; Settings uses the toolkitSettingsCard, which renders with the same card brushes — so Tags, Shared parameters, Trash and Settings are now consistent on background and border. (Content width was already consistent: all four useMaxWidth=720,Padding=24,HorizontalAlignment=Stretch.)How
GlyphNameLookup(two-way glyph↔name map).TagIconRowViewModel.GlyphTextresolves display/edit through it, falling back to hex via the existingGlyphInput.ShellViewModelgained an optionalIGlyphCatalogueProvider: production DI injects it (names work); the existing unit tests constructShellViewModelwithout it (lookup empty → hex fallback), so nothing broke.OpenTagIconsbuilds the lookup from the catalogue when the view opens.Testing
GlyphTextname-display, name→glyph resolution, and hex-fallback cases).Note
The custom cards use corner radius 8; the toolkit
SettingsCarddefaults to 4 — a pre-existing difference left as-is, since the brief was to match tag cards to the Shared parameters cards (8). Easy to unify later if wanted.🤖 Generated with Claude Code