Merged
Conversation
daobrien
approved these changes
Jul 29, 2021
Collaborator
daobrien
left a comment
daobrien
left a comment
There was a problem hiding this comment.
I'm pretty sure this is good to go. I've been through a lot of it with Julian and I think Sam ack'd it as well so I'm going to merge it so we can move on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi editors!
In collaboration with David, I have now implemented my planned updates and additions to the Red Hat Style Guide.
Please could you each review the changes by Wednesday 28 July and provide your comments?
The plan is to release the updated style guide by the end of July.
Many thanks!