Skip to content

Commit 15b0b84

Browse files
Merge pull request #9411 from JeraldJF/angular-16-upgrade
Angular 16 upgrade - Rxjs and Ngx chips version upgrade
2 parents 7937c46 + dce9491 commit 15b0b84

File tree

11 files changed

+13
-15
lines changed

11 files changed

+13
-15
lines changed

src/app/client/angular.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
"./node_modules/leaflet/dist/leaflet.css",
9696
"src/assets/styles/styles.scss",
9797
"node_modules/video.js/dist/video-js.min.css",
98-
"node_modules/katex/dist/katex.min.css",
9998
"./node_modules/@project-sunbird/sb-themes/themes/themes-material_UI.scss",
10099
"./node_modules/@project-sunbird/sb-themes/themes/themes-df.scss",
101100
"./node_modules/@project-sunbird/sb-themes/themes/themes-portal.scss",
@@ -121,7 +120,6 @@
121120
"node_modules/datatables.net/js/jquery.dataTables.js",
122121
"src/assets/libs/semantic-ui/sidebar.min.js",
123122
"node_modules/leaflet/dist/leaflet.js",
124-
"./node_modules/katex/dist/katex.min.js",
125123
"node_modules/jquery.fancytree/dist/jquery.fancytree-all-deps.min.js",
126124
"src/assets/scripts/preserve-fancytree.js",
127125
"src/assets/libs/semantic-ui/modal.min.js",

src/app/client/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,12 @@
129129
"ng2-cache-service": "1.1.1",
130130
"ng2-charts": "5.0.4",
131131
"ngx-bootstrap": "8.0.0",
132-
"ngx-chips": "2.2.2",
132+
"ngx-chips": "3.0.0",
133133
"ngx-daterangepicker-material": "6.0.4",
134134
"ngx-device-detector": "4.0.1",
135135
"ngx-filesize": "3.0.1",
136136
"ngx-infinite-scroll": "8.0.2",
137-
"rxjs": "6.5.5",
137+
"rxjs": "7.8.1",
138138
"sass": "1.56.1",
139139
"sb-svg2pdf-v13": "1.0.0",
140140
"sb-tag-manager": "3.9.19",

src/app/client/src/app/modules/dashboard/components/report/report.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ export class ReportComponent implements OnInit {
481481
switchMap(reports => {
482482
if (this.reportService.isUserSuperAdmin()) {
483483
return this.reportService.getMaterializedChildRows(reports).pipe(
484-
map(response => {
484+
map((response: any[]) => {
485485
const [reportObj] = response;
486486
return _.get(reportObj, 'children');
487487
})

src/app/client/src/app/modules/dashboard/services/report/report.service.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ describe('ReportService', () => {
471471
const input = [{ isParameterized: true, children: [], parameters: ['$board'], reportid: '123' }];
472472
jest.spyOn(reportService, 'getParameterValues').mockReturnValue({ masterData: () => of(['CBSE']) } as any);
473473
jest.spyOn(reportService, 'getParameterFromHash').mockReturnValue('NCERT');
474-
reportService['getMaterializedChildRows'](input).subscribe(res => {
474+
reportService['getMaterializedChildRows'](input).subscribe((res: any[]) => {
475475
expect(res).toBeDefined();
476476
expect(res.length).toBe(1);
477477
expect(reportService.getParameterValues).toHaveBeenCalled();
@@ -486,7 +486,7 @@ describe('ReportService', () => {
486486
it('should return the same report for unknow parameters', () => {
487487
const input = [{ isParameterized: true, children: [], parameters: ['$board'], reportid: '123' }];
488488
jest.spyOn(reportService, 'getParameterValues').mockReturnValue(null);
489-
reportService['getMaterializedChildRows'](input).subscribe(res => {
489+
reportService['getMaterializedChildRows'](input).subscribe((res: any[]) => {
490490
expect(res).toBeDefined();
491491
expect(res.length).toBe(1);
492492
expect(res).toEqual(input);
@@ -496,7 +496,7 @@ describe('ReportService', () => {
496496
it('should return the same report if the api to get masterData fails', () => {
497497
const input = [{ isParameterized: true, children: [], parameters: ['$board'], reportid: '123' }];
498498
jest.spyOn(reportService, 'getParameterValues').mockReturnValue({ masterData: () => throwError('') } as any);
499-
reportService['getMaterializedChildRows'](input).subscribe(res => {
499+
reportService['getMaterializedChildRows'](input).subscribe((res: any[]) => {
500500
expect(res).toBeDefined();
501501
expect(res.length).toBe(1);
502502
expect(res).toEqual(input);

src/app/client/src/app/modules/dashboard/services/report/report.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export class ReportService {
7979
return this.fetchDataSource(_.get(source, 'path'), _.get(source, 'id'));
8080
});
8181
return forkJoin(...apiCalls).pipe(
82-
mergeMap(response => {
82+
mergeMap((response: any[]) => {
8383

8484
response = response.filter(function(item) { if (item ) { return item.loaded = true; } });
8585
return this.getFileMetaData(dataSources).pipe(

src/app/client/src/app/modules/player-helper/service/quml-player-v2/quml-player-v2.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class QumlPlayerV2Service implements QuestionCursor, EditorCursor {
3939
const hierarchy = this.playerService.getQuestionSetHierarchy(identifier);
4040
const questionSetResponse = this.playerService.getQuestionSetRead(identifier);
4141

42-
return forkJoin([hierarchy, questionSetResponse]).pipe(map(res => {
42+
return forkJoin([hierarchy, questionSetResponse]).pipe(map((res: any[]) => {
4343
const questionSet = _.get(res[0], 'result.questionset');
4444
const questionsetData = _.get(res[1], 'result.questionset');
4545
_.merge(questionSet, this.playerService.getProperties(questionsetData, this.configService.editorConfig.QUESTIONSET_EDITOR.additionalProperties))

src/app/client/src/app/modules/public/module/offline/components/content-manager/content-manager.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export class ContentManagerComponent implements OnInit, OnDestroy {
2525
localStatusArr = ['inProgress', 'inQueue', 'resume', 'resuming', 'pausing', 'canceling'];
2626
cancelId: string;
2727
apiCallTimer = timer(1000, 3000).pipe(filter(data => !data || (this.callContentList)));
28-
apiCallSubject = new Subject();
28+
apiCallSubject = new Subject<void>();
2929
completedCount: number;
3030
handledFailedList = [];
3131
unHandledFailedList = [];

src/app/client/src/app/modules/public/module/offline/components/telemetry-import/telemetry-import.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class TelemetryImportComponent implements OnInit, OnDestroy {
1717
public unsubscribe$ = new Subject<void>();
1818
importedFilesSize = 0;
1919
callImportList = false;
20-
apiCallSubject = new Subject();
20+
apiCallSubject = new Subject<void>();
2121
contentStatusObject = {};
2222
localStatusArr = ['inProgress', 'inQueue'];
2323
apiCallTimer = timer(1000, 3000).pipe(filter(data => !data || (this.callImportList)));

src/app/client/src/app/modules/shared-feature/components/user-location/user-location.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ export class UserLocationComponent implements OnInit, OnDestroy, AfterViewInit {
345345
let response1: any;
346346
response1 = this.updateDeviceProfileData(data, locationDetails);
347347
const response2 = this.updateUserProfileData(data);
348-
forkJoin([response1, response2]).subscribe((res) => {
348+
forkJoin([response1, response2]).subscribe((res: any[]) => {
349349
if (!_.isEmpty(res[0])) {
350350
this.telemetryLogEvents('Device Profile', true);
351351
}

src/app/client/src/app/modules/shared/services/util/util.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { TransposeTermsPipe } from '../../pipes/transposeTerms/transposeTerms.pi
1414
export class UtilService {
1515
static singletonInstance: UtilService;
1616
public showAppPopUp = false;
17-
private searchQuery = new Subject<any>();
17+
private searchQuery = new Subject<void>();
1818
public searchQuery$ = this.searchQuery.asObservable();
1919
public languageChange = new EventEmitter<ILanguage>();
2020
public hideHeaderTabs = new EventEmitter<boolean>();

0 commit comments

Comments
 (0)