Skip to content

Angular 16 upgrade - Rxjs and Ngx chips version upgrade#9411

Merged
pallakartheekreddy merged 6 commits intoSunbird-Ed:release-8.1.0from
JeraldJF:angular-16-upgrade
Nov 11, 2025
Merged

Angular 16 upgrade - Rxjs and Ngx chips version upgrade#9411
pallakartheekreddy merged 6 commits intoSunbird-Ed:release-8.1.0from
JeraldJF:angular-16-upgrade

Conversation

@JeraldJF
Copy link
Copy Markdown
Collaborator

SunbirdEd - Portal


Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.


Please choose applicable option

Example

  • Applicable
  • Not applicable

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (additive changes to improve performance)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades RxJS from version 6.5.5 to 7.8.1 and ngx-chips from 2.2.2 to 3.0.0 as part of the Angular 16 upgrade. The changes primarily address stricter type requirements in RxJS 7, where Subject.next() and ReplaySubject.next() no longer accept being called without parameters when typed as Subject<void>. However, the implementation uses a problematic workaround by changing types to Subject<void | any> and passing hardcoded strings like "LOADING" instead of using proper TypeScript types.

Key changes:

  • Package version bumps for RxJS (6.5.5 → 7.8.1) and ngx-chips (2.2.2 → 3.0.0)
  • Type annotations added to Observable callbacks to satisfy RxJS 7's stricter typing
  • Workaround implementations for void-typed Subjects using void | any union types
  • Removal of katex references from angular.json build configuration

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
package.json Updates RxJS to 7.8.1 and ngx-chips to 3.0.0
lazzy-load-script.service.ts Changes ReplaySubject type to void | any and passes "LOADING" string to next()
util.service.ts Changes Subject type to void | any and passes "LOADING" string to next()
user-location.component.ts Adds type annotations to forkJoin callbacks (contains a bug in error handler)
telemetry-import.component.ts Correctly types Subject as Subject<void>
content-manager.component.ts Correctly types Subject as Subject<void>
quml-player-v2.service.ts Adds type annotation to forkJoin map callback
report.service.ts Adds type annotation to forkJoin mergeMap callback
report.service.spec.ts Adds type annotations to observable subscribe callbacks in tests
report.component.ts Adds type annotation to map callback
angular.json Removes katex CSS and JS file references from build configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pallakartheekreddy pallakartheekreddy merged commit 15b0b84 into Sunbird-Ed:release-8.1.0 Nov 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants