Angular 16 upgrade - Rxjs and Ngx chips version upgrade#9411
Angular 16 upgrade - Rxjs and Ngx chips version upgrade#9411pallakartheekreddy merged 6 commits intoSunbird-Ed:release-8.1.0from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades RxJS from version 6.5.5 to 7.8.1 and ngx-chips from 2.2.2 to 3.0.0 as part of the Angular 16 upgrade. The changes primarily address stricter type requirements in RxJS 7, where Subject.next() and ReplaySubject.next() no longer accept being called without parameters when typed as Subject<void>. However, the implementation uses a problematic workaround by changing types to Subject<void | any> and passing hardcoded strings like "LOADING" instead of using proper TypeScript types.
Key changes:
- Package version bumps for RxJS (6.5.5 → 7.8.1) and ngx-chips (2.2.2 → 3.0.0)
- Type annotations added to Observable callbacks to satisfy RxJS 7's stricter typing
- Workaround implementations for void-typed Subjects using
void | anyunion types - Removal of katex references from angular.json build configuration
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates RxJS to 7.8.1 and ngx-chips to 3.0.0 |
| lazzy-load-script.service.ts | Changes ReplaySubject type to void | any and passes "LOADING" string to next() |
| util.service.ts | Changes Subject type to void | any and passes "LOADING" string to next() |
| user-location.component.ts | Adds type annotations to forkJoin callbacks (contains a bug in error handler) |
| telemetry-import.component.ts | Correctly types Subject as Subject<void> |
| content-manager.component.ts | Correctly types Subject as Subject<void> |
| quml-player-v2.service.ts | Adds type annotation to forkJoin map callback |
| report.service.ts | Adds type annotation to forkJoin mergeMap callback |
| report.service.spec.ts | Adds type annotations to observable subscribe callbacks in tests |
| report.component.ts | Adds type annotation to map callback |
| angular.json | Removes katex CSS and JS file references from build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/app/client/src/app/modules/shared/services/util/util.service.ts
Outdated
Show resolved
Hide resolved
src/app/client/src/app/modules/shared/services/util/util.service.ts
Outdated
Show resolved
Hide resolved
src/app/client/src/app/service/LazzyLoadScript/lazzy-load-script.service.ts
Outdated
Show resolved
Hide resolved
src/app/client/src/app/service/LazzyLoadScript/lazzy-load-script.service.ts
Outdated
Show resolved
Hide resolved
...pp/client/src/app/modules/shared-feature/components/user-location/user-location.component.ts
Outdated
Show resolved
Hide resolved
15b0b84
into
Sunbird-Ed:release-8.1.0
SunbirdEd - Portal
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please choose applicable option
Example
Type of change
Please choose appropriate options.
Checklist: