SBCOSS-I256: Pass framework routing configurations to editors#9404
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR passes framework routing configuration values into both the Generic and Content editors, enabling them to construct framework API URLs from centralized config.
- Adds fwApiSlug and getCategorysUrl to window.config in both editors
- Introduces PUBLIC_URL_PREFIX and READ_URL in the shared URL config
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/client/src/app/modules/workspace/components/content-editors/generic-editor/generic-editor.component.ts | Sets fwApiSlug and getCategorysUrl on window.config for the generic editor. |
| src/app/client/src/app/modules/workspace/components/content-editors/content-editor/content-editor.component.ts | Sets fwApiSlug and getCategorysUrl on window.config for the content editor. |
| src/app/client/src/app/modules/shared/services/config/url.config.json | Adds PUBLIC_URL_PREFIX and READ_URL keys to the URL config. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../app/modules/workspace/components/content-editors/generic-editor/generic-editor.component.ts
Show resolved
Hide resolved
.../app/modules/workspace/components/content-editors/content-editor/content-editor.component.ts
Show resolved
Hide resolved
8a47408
into
Sunbird-Ed:release-8.1.0
SunbirdEd - Portal
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please choose applicable option
Example
Type of change
Please choose appropriate options.
Checklist: