Angular 16 migration changes#9410
Conversation
Angular 16 upgrade
Angular 16 upgrade
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Angular application from version 14 to version 16, along with related dependencies and library updates. The upgrade includes updating chart libraries, removing the deprecated UCI admin module, and migrating from the older ng2-semantic-ui-v9 to @project-sunbird/ng2-semantic-ui.
Key Changes
- Angular upgrade: Core Angular packages upgraded from 14.x to 16.2.12
- Chart library migration: Transitioned from
ng2-charts2.4.2 to 5.0.4 with associated mocks and test configurations - Dependency cleanup: Removed deprecated UCI admin module and its routing, updated semantic UI package references throughout the codebase
Reviewed Changes
Copilot reviewed 72 out of 74 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/client/package.json | Upgraded Angular core packages to v16, updated dependencies including ng2-charts, angular-datatables, and various @project-sunbird packages; removed postinstall ngcc script |
| src/app/client/angular.json | Updated asset paths for web component libraries from lib/assets/ to assets/ |
| src/app/client/src/app/app.routing.ts | Removed deprecated relativeLinkResolution option and uci-admin route |
| src/app/client/src/app/app.module.ts | Updated semantic UI import to @project-sunbird/ng2-semantic-ui |
| src/app/client/src/app/modules//.module.ts (multiple) | Migrated all semantic UI imports from ng2-semantic-ui-v9 to @project-sunbird/ng2-semantic-ui |
| src/app/client/src/app/modules/shared/components/alert-modal/* | Updated modal component to handle API changes in semantic UI v8, added context getter and adjusted type signatures |
| src/app/client/src/app/modules/dashboard/dashboard.module.ts | Changed from ChartsModule to NgChartsModule for ng2-charts v5 |
| src/app/client/src/app/modules/dashboard/components/course-progress/course-progress.component.ts | Added explicit Number() conversion for totalCount comparison |
| src/app/client/src/app/modules/uci-admin/* (multiple) | Removed entire UCI admin module including components, routing, and tests |
| src/app/client/mocks/*.js | Added mock files for chart.js and ng2-charts to support Jest testing |
| src/app/client/jest-global-mocks.ts | Added global Chart.js mocks for test environment |
| src/app/client/src/app/modules/observation/components/observation-details/observation-details.component.scss | Updated SCSS import to remove tilde prefix |
| .github/workflows/image-push.yml | Added browserslist database update step before building |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SunbirdEd - Portal
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please choose applicable option
Example
Type of change
Please choose appropriate options.
Checklist: