Skip to content

Angular 16 migration changes#9410

Merged
pallakartheekreddy merged 13 commits intorelease-8.1.0from
v16
Nov 7, 2025
Merged

Angular 16 migration changes#9410
pallakartheekreddy merged 13 commits intorelease-8.1.0from
v16

Conversation

@JeraldJF
Copy link
Copy Markdown
Collaborator

@JeraldJF JeraldJF commented Nov 7, 2025

SunbirdEd - Portal


Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.


Please choose applicable option

Example

  • Applicable
  • Not applicable

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (additive changes to improve performance)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JeraldJF JeraldJF changed the title V16 Angular 16 migration changes Nov 7, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Angular application from version 14 to version 16, along with related dependencies and library updates. The upgrade includes updating chart libraries, removing the deprecated UCI admin module, and migrating from the older ng2-semantic-ui-v9 to @project-sunbird/ng2-semantic-ui.

Key Changes

  • Angular upgrade: Core Angular packages upgraded from 14.x to 16.2.12
  • Chart library migration: Transitioned from ng2-charts 2.4.2 to 5.0.4 with associated mocks and test configurations
  • Dependency cleanup: Removed deprecated UCI admin module and its routing, updated semantic UI package references throughout the codebase

Reviewed Changes

Copilot reviewed 72 out of 74 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/app/client/package.json Upgraded Angular core packages to v16, updated dependencies including ng2-charts, angular-datatables, and various @project-sunbird packages; removed postinstall ngcc script
src/app/client/angular.json Updated asset paths for web component libraries from lib/assets/ to assets/
src/app/client/src/app/app.routing.ts Removed deprecated relativeLinkResolution option and uci-admin route
src/app/client/src/app/app.module.ts Updated semantic UI import to @project-sunbird/ng2-semantic-ui
src/app/client/src/app/modules//.module.ts (multiple) Migrated all semantic UI imports from ng2-semantic-ui-v9 to @project-sunbird/ng2-semantic-ui
src/app/client/src/app/modules/shared/components/alert-modal/* Updated modal component to handle API changes in semantic UI v8, added context getter and adjusted type signatures
src/app/client/src/app/modules/dashboard/dashboard.module.ts Changed from ChartsModule to NgChartsModule for ng2-charts v5
src/app/client/src/app/modules/dashboard/components/course-progress/course-progress.component.ts Added explicit Number() conversion for totalCount comparison
src/app/client/src/app/modules/uci-admin/* (multiple) Removed entire UCI admin module including components, routing, and tests
src/app/client/mocks/*.js Added mock files for chart.js and ng2-charts to support Jest testing
src/app/client/jest-global-mocks.ts Added global Chart.js mocks for test environment
src/app/client/src/app/modules/observation/components/observation-details/observation-details.component.scss Updated SCSS import to remove tilde prefix
.github/workflows/image-push.yml Added browserslist database update step before building

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pallakartheekreddy pallakartheekreddy merged commit 7937c46 into release-8.1.0 Nov 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants