Skip to content

Dashboard module circular dependency issue fix#9413

Merged
sntiwari1 merged 5 commits intoSunbird-Ed:release-8.1.0from
JeraldJF:angular-16-upgrade
Nov 13, 2025
Merged

Dashboard module circular dependency issue fix#9413
sntiwari1 merged 5 commits intoSunbird-Ed:release-8.1.0from
JeraldJF:angular-16-upgrade

Conversation

@JeraldJF
Copy link
Copy Markdown
Collaborator

SunbirdEd - Portal


Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.


Please choose applicable option

Example

  • Applicable
  • Not applicable

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (additive changes to improve performance)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JeraldJF JeraldJF changed the title Angular 16 upgrade Dashboard module circular dependency issue fix Nov 12, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses circular dependency issues between the DashboardModule and ProgramDashboardModule by creating a new DashboardSharedModule to house commonly shared components, refactoring barrel exports, and updating imports to use direct paths instead of index barrels.

Key Changes:

  • Created DashboardSharedModule containing DataTableComponent and FilterComponent that are shared across modules
  • Updated dashboard/index.ts to only export services and interfaces, avoiding module exports that cause circular dependencies
  • Replaced component barrel imports with direct component imports in routing and module files

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
program-dashboard.module.ts Updated to import DashboardSharedModule instead of DashboardModule to break circular dependency
program-datasets.component.spec.ts Changed import path for ReportService from barrel export to direct services path
dashboard/index.ts Removed component and module exports, now only exports services and interfaces to prevent circular dependencies
dashboard.module.ts Refactored to use direct component imports, imports DashboardSharedModule, removed DataTableComponent and FilterComponent from declarations, updated exports
dashboard-shared.module.ts New shared module created to export DataTableComponent and FilterComponent for use by other modules
dashboard-routing.module.ts Updated to use direct component imports and export DASHBOARD_ROUTES constant for reuse
package.json Upgraded Chart.js from 2.9.4 to 4.4.0 and added chartjs-plugin-annotation, added postinstall script for browserslist
pull_request.yml Added browserslist database update step before dependency installation in CI workflows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sntiwari1 sntiwari1 merged commit 3d8fdf9 into Sunbird-Ed:release-8.1.0 Nov 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants