[RFC] Initial High DPI support; fix aarch64 macOS crash on launch by qwertychouskie · Pull Request #3499 · SuperTux/supertux

qwertychouskie · 2025-12-31T09:12:19Z

Wanted to get feedback on this before doing the work to make proper separated PRs. Thoughts?

Tested on macOS

It's admittedly a minor annoyance, but on systems set to show hidden files by default, the `.fseventsd` folder ends up partially covering the logo.

swagtoy · 2025-12-31T09:23:35Z

I would really prefer if you kept the HIDPI changes in a separate PR, as itll he difficult for me to cherry pick out the cmake fixes here.

I hate to be a bother; but its unlikely i want to mess directly with the video backend (as this commit pokes at some other areas) as i want to test it a little more thoroughly before release.

Sorry :/ If you could rebase/split it into 2 that would be greatly appreciated

swagtoy · 2025-12-31T09:25:57Z

Oh goodness i completely ignored the original message. Carry on

Ill review in the morning. Tobbi will be able to test it too

tobbi · 2025-12-31T09:29:33Z

Ill review in the morning. Tobbi will be able to test it too

Unfortunately, no. I'm on an older Intel Mac, which doesn't enforce code signing this strictly (otherwise I'd have caught this issue earlier). Also, different architecture.

qwertychouskie · 2025-12-31T10:13:12Z

I would really prefer if you kept the HIDPI changes in a separate PR, as itll he difficult for me to cherry pick out the cmake fixes here.

Oh goodness i completely ignored the original message. Carry on

FWIW, the commits themselves are cleanly separated, I just haven't done a final code review and spun them off to separate branches yet.

Brockengespenst · 2025-12-31T10:36:10Z

Another thing I just noticed: The Apple Silicon builds require Rosetta for some reasons. Maybe you would also like to address this?

qwertychouskie · 2026-01-01T04:41:49Z

Another thing I just noticed: The Apple Silicon builds require Rosetta for some reasons. Maybe you would also like to address this?

Are you seeing a prompt to install Rosetta when launching on an Apple Silicon system? All the binaries and libraries in the app appear to be native aarch64.

Packages that have a shell script as their primary executable are treated as x86-64 by default for compatibility reasons. Adding LSArchitecturePriority to Info.plist should make the app's detected architecture be correct, see https://apple.stackexchange.com/a/474471/167476

qwertychouskie · 2026-01-01T05:02:17Z

OK, I think the issue of requiring Rosetta should be fixed, though it will need to be tested by someone with an arm64 Mac without Rosetta installed to confirm.

swagtoy · 2026-01-01T05:01:35Z

mk/cmake/SuperTux/BuildCPack.cmake

  install(CODE "
-       if(\"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/\" MATCHES \".*\\\\.app.*\")
-       include(BundleUtilities)
-       fixup_bundle(\"${APPS}\"   \"\"   \"${DIRS}\")
-       endif()
-       ")
+    if(\"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/\" MATCHES \".*\\\\.app.*\")
+      include(BundleUtilities)
+
+      # Override the default embedded path to put libraries in Contents/Frameworks
+      # instead of Contents/Resources/Frameworks
+      # The executable is at Contents/Resources/bin/supertux2, so we need ../../Frameworks
+      function(gp_item_default_embedded_path_override item default_embedded_path_var)
+        set(path \"@executable_path/../../Frameworks\")
+        set(\${default_embedded_path_var} \"\${path}\" PARENT_SCOPE)
+      endfunction()
+
+      fixup_bundle(\"${APPS}\"   \"\"   \"${DIRS}\")
+
+      # Clean up redundant library directory - fixup_bundle already copied them to Frameworks
+      file(REMOVE_RECURSE \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/lib\")
+    endif()
+  ")


I would say "use a configure file for this" but it's generated CMake.............. :') Is there anything we can do here?

swagtoy · 2026-01-01T05:02:52Z

mk/cmake/SuperTux/BuildCPack.cmake

+set(CPACK_DEBIAN_PACKAGE_DESCRIPTION "Classic 2D jump 'n run sidescroller with Tux\n SuperTux is a jump'n'run game with strong inspiration from the Super Mario Bros. games for the various Nintendo platforms.\n \n Run and jump through multiple worlds, fighting off enemies by jumping on them, bumping them from below or tossing objects at them, grabbing power-ups and other stuff on the way.\n .\n This is a development snapshot of SuperTux. It may suffer from critical bugs and has not been fully tested. \n .\n Homepage: https://supertux.org/")
 set(CPACK_DEBIAN_PACKAGE_SECTION "games")
 set(CPACK_RPM_PACKAGE_NAME "supertux2")
-set(CPACK_RPM_PACKAGE_DESCRIPTION "Classic 2D jump 'n run sidescroller with Tux\n SuperTux is a classic 2D jump 'n run sidescroller game in a similar\n style like the original SuperMario games. This release of SuperTux\n features 9 enemies, 26 playable levels, software and OpenGL rendering\n modes, configurable joystick and keyboard input, new music and\n completely redone graphics.\n .\n This is a development snapshot of SuperTux. It may suffer from\n critical bugs and has not been fully tested. \n .\n Homepage: http://supertux.lethargik.org/")
+set(CPACK_RPM_PACKAGE_DESCRIPTION "Classic 2D jump 'n run sidescroller with Tux\n SuperTux is a jump'n'run game with strong inspiration from the Super Mario Bros. games for the various Nintendo platforms.\n \n Run and jump through multiple worlds, fighting off enemies by jumping on them, bumping them from below or tossing objects at them, grabbing power-ups and other stuff on the way.\n .\n This is a development snapshot of SuperTux. It may suffer from critical bugs and has not been fully tested. \n .\n Homepage: https://supertux.org/")


Really not sure why this isn't a separate variable in it's own. Have you checked the newlines btw?

Also TBH this description is pretty lengthy. I kept the ebuild description to just "A run n' jump platforming game featuring Tux the penguin"

swagtoy · 2026-01-01T05:07:33Z

src/video/sdlbase_video_system.cpp

  flags |= SDL_WINDOW_RESIZABLE;
+  flags |= SDL_WINDOW_ALLOW_HIGHDPI;


Suggested change

flags |= SDL_WINDOW_RESIZABLE;

flags |= SDL_WINDOW_ALLOW_HIGHDPI;

flags |= SDL_WINDOW_RESIZABLE | SDL_WINDOW_ALLOW_HIGHDPI;

swagtoy · 2026-01-01T05:10:28Z

src/video/viewport.cpp

+  return Vector(static_cast<float>(pixel_x - m_rect.left) / m_scale.x,
+                static_cast<float>(pixel_y - m_rect.top) / m_scale.y);


/me wonders if you could just / m_scale the vector...

swagtoy · 2026-01-01T05:11:33Z

src/video/sdl/sdl_video_system.cpp

+    // Compute HiDPI scale factor for coordinate conversion
+    Size window_size = get_window_size();
+    float pixel_scale = (window_size.width > 0) ?
+      static_cast<float>(output_w) / static_cast<float>(window_size.width) : 1.0f;


Suggested change

static_cast<float>(output_w) / static_cast<float>(window_size.width) : 1.0f;

(static_cast<float>(output_w) / static_cast<float>(window_size.width)) : 1.0f;

Brockengespenst · 2026-01-01T10:50:23Z

Are you seeing a prompt to install Rosetta when launching on an Apple Silicon system? All the binaries and libraries in the app appear to be native aarch64.

Exactly.

OK, I think the issue of requiring Rosetta should be fixed, though it will need to be tested by someone with an arm64 Mac without Rosetta installed to confirm.

I cherry-picked your CPack related commits and can confirm that the prompt to install Rosetta does not appear anymore.

Unfortunately the game does not launch:

./SuperTux.app/Contents/MacOS/SuperTux: line 9: /Volumes/SuperTux master-accde090b/SuperTux.app/Contents/Resources/bin/supertux2: No such file or directory
./SuperTux.app/Contents/MacOS/SuperTux: line 9: exec: /Volumes/SuperTux master-accde090b/SuperTux.app/Contents/Resources/bin/supertux2: cannot execute: No such file or directory

In my local build, the supertux2 executable is placed in SuperTux.app/Contents/Resources/games/, instead of the bin directory, most likely due to

  if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND DISABLE_CPACK_BUNDLING)
    set(INSTALL_SUBDIR_BIN "SuperTux.app/Contents/MacOS" CACHE STRING "Installation subdir for binaries")
    set(INSTALL_SUBDIR_SHARE "SuperTux.app/Contents/Resources/data" CACHE STRING "Installation subdir for data")
    set(INSTALL_SUBDIR_DOC "SuperTux.app/Contents/Resources" CACHE STRING "Installation subdir for docs")
  else()
    set(INSTALL_SUBDIR_BIN "games" CACHE STRING "Installation subdir for binaries")
    set(INSTALL_SUBDIR_SHARE "share/games/supertux2" CACHE STRING "Installation subdir for data")
    set(INSTALL_SUBDIR_DOC "share/doc/supertux2" CACHE STRING "Installation subdir for docs")
  endif()

In my case DISABLE_CPACK_BUNDLING is false, as I do not see that this is somehow set to true in the github workflows.

qwertychouskie · 2026-01-01T12:53:40Z

Are you seeing a prompt to install Rosetta when launching on an Apple Silicon system? All the binaries and libraries in the app appear to be native aarch64.

Exactly.

OK, I think the issue of requiring Rosetta should be fixed, though it will need to be tested by someone with an arm64 Mac without Rosetta installed to confirm.

I cherry-picked your CPack related commits and can confirm that the prompt to install Rosetta does not appear anymore.

Unfortunately the game does not launch:
./SuperTux.app/Contents/MacOS/SuperTux: line 9: /Volumes/SuperTux master-accde090b/SuperTux.app/Contents/Resources/bin/supertux2: No such file or directory
./SuperTux.app/Contents/MacOS/SuperTux: line 9: exec: /Volumes/SuperTux master-accde090b/SuperTux.app/Contents/Resources/bin/supertux2: cannot execute: No such file or directory
In my local build, the supertux2 executable is placed in SuperTux.app/Contents/Resources/games/, instead of the bin directory, most likely due to
  if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND DISABLE_CPACK_BUNDLING)
    set(INSTALL_SUBDIR_BIN "SuperTux.app/Contents/MacOS" CACHE STRING "Installation subdir for binaries")
    set(INSTALL_SUBDIR_SHARE "SuperTux.app/Contents/Resources/data" CACHE STRING "Installation subdir for data")
    set(INSTALL_SUBDIR_DOC "SuperTux.app/Contents/Resources" CACHE STRING "Installation subdir for docs")
  else()
    set(INSTALL_SUBDIR_BIN "games" CACHE STRING "Installation subdir for binaries")
    set(INSTALL_SUBDIR_SHARE "share/games/supertux2" CACHE STRING "Installation subdir for data")
    set(INSTALL_SUBDIR_DOC "share/doc/supertux2" CACHE STRING "Installation subdir for docs")
  endif()
In my case DISABLE_CPACK_BUNDLING is false, as I do not see that this is somehow set to true in the github workflows.

I'm building with this:

mkdir build
cd build
rm -rf * && cmake -DINSTALL_SUBDIR_BIN=bin .. && make -j16 && cpack -G Bundle

I assume this is being set somewhere in the CI scripts, since the CI build uses the correct directory.

You can also grab the package produced by the CI run on this MR for easy testing: https://github.com/SuperTux/supertux/actions/runs/20632897867/artifacts/5001656600

Brockengespenst · 2026-01-01T13:21:20Z

Ah, correct, the following variables are passed to CMake in the CI script:

-DCMAKE_INSTALL_PREFIX=/usr
-DINSTALL_SUBDIR_BIN=bin
-DINSTALL_SUBDIR_SHARE=share/supertux2

With that given, SuperTux.app launches as expected on Apple Silicon (without Rosetta). From my point of view, the macOs bundle related part of this PR is working.

tobbi · 2026-01-24T17:24:35Z

@qwertychouskie Could you apply the review comments by @swagtoy (at least the ones that are clear)

qwertychouskie added 7 commits December 31, 2025 01:10

Initial High DPI support

d6bef7e

Tested on macOS

Use physical pixels for window size configuration in options menu

1a7e413

Update CPack package descriptions based on README.md

adf5d2b

Update reference to old website domain to current domain

0e5f2b7

Update reference to defunct mailing list in CPack config

2d92b4b

Rework macOS packaging to make the native Apple Silicon package work

9d3d13a

Make sure not include .fseventsd folder and similar in the DMG

8849729

It's admittedly a minor annoyance, but on systems set to show hidden files by default, the `.fseventsd` folder ends up partially covering the logo.

qwertychouskie changed the title ~~[RFC] Initial High DPI support; fix macOS build~~ [RFC] Initial High DPI support; fix aarch64 macOS crash on launch Dec 31, 2025

qwertychouskie added 2 commits December 31, 2025 20:59

swagtoy requested changes Jan 1, 2026

View reviewed changes

tobbi mentioned this pull request Jan 5, 2026

[Crash]: Unable to start SuperTux 0.7.0 beta 1 or latest nightly build on macOS Tahoe (arm64) #3529

Open

6 tasks

swagtoy force-pushed the master branch 2 times, most recently from 806ca6a to c12b71b Compare March 15, 2026 04:42

qwertychouskie mentioned this pull request Mar 23, 2026

With XQuartz 2.8.5, drawing on the display is incomplete. XQuartz/XQuartz#323

Closed

		flags \|= SDL_WINDOW_RESIZABLE;
		flags \|= SDL_WINDOW_ALLOW_HIGHDPI;

	flags \|= SDL_WINDOW_RESIZABLE;
	flags \|= SDL_WINDOW_ALLOW_HIGHDPI;
	flags \|= SDL_WINDOW_RESIZABLE \| SDL_WINDOW_ALLOW_HIGHDPI;

		return Vector(static_cast<float>(pixel_x - m_rect.left) / m_scale.x,
		static_cast<float>(pixel_y - m_rect.top) / m_scale.y);

	static_cast<float>(output_w) / static_cast<float>(window_size.width) : 1.0f;
	(static_cast<float>(output_w) / static_cast<float>(window_size.width)) : 1.0f;

Uh oh!

Conversation

qwertychouskie commented Dec 31, 2025

Uh oh!

swagtoy commented Dec 31, 2025

Uh oh!

swagtoy commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobbi commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qwertychouskie commented Dec 31, 2025

Uh oh!

Brockengespenst commented Dec 31, 2025

Uh oh!

qwertychouskie commented Jan 1, 2026

Uh oh!

qwertychouskie commented Jan 1, 2026

Uh oh!

swagtoy Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

swagtoy Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

swagtoy Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

swagtoy Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

swagtoy Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

swagtoy Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Brockengespenst commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qwertychouskie commented Jan 1, 2026

Uh oh!

Brockengespenst commented Jan 1, 2026

Uh oh!

tobbi commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

swagtoy commented Dec 31, 2025 •

edited

Loading

tobbi commented Dec 31, 2025 •

edited

Loading

Brockengespenst commented Jan 1, 2026 •

edited

Loading