Refactor agent core startup solo#89
Conversation
…' into refactor-agent-core-startup-solo
…' into refactor-agent-core-startup-solo
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| When os.fork(), the service instance should be changed to a new one by appending pid. | ||
| """ | ||
| python_version: tuple = sys.version_info[:2] | ||
| if python_version[0] < 3 and python_version[1] < 7: |
There was a problem hiding this comment.
Unsupported operand: < is not supported for operand types typing.Union[int, str] and int.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| When os.fork(), the service instance should be changed to a new one by appending pid. | ||
| """ | ||
| python_version: tuple = sys.version_info[:2] | ||
| if python_version[0] < 3 and python_version[1] < 7: |
There was a problem hiding this comment.
Unsupported operand: < is not supported for operand types typing.Union[int, str] and int.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This PR is made of two tightly coupled parts: * Total rewrite of agent startup logic from module functions -> singleton class. (some other logic was changed in meter to fix wrong forking behavior) * Provide experimental support for os.fork(), exposed as an option. * A demo directory to provide easier access to oap/kafka/demoservices (for contributors). Minor changes: * Docs: fixed some missed ones over time. * Fixed a redis bug.
1 participant
CHANGELOG.md.