[Shop] Render the taxons list in the configured order and skip disabled taxons - #205
Open
JustMordeckai wants to merge 2 commits into
Open
[Shop] Render the taxons list in the configured order and skip disabled taxons#205JustMordeckai wants to merge 2 commits into
JustMordeckai wants to merge 2 commits into
Conversation
…p disabled taxons
crydotsnake
suggested changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaxonsListContentElementRendererfetched the configured taxons with a barefindBy(['code' => $codes]): the order the contributor picked in the admin form was thrown away in favour of database order, and taxons disabled in the catalog kept being rendered while the rest of the shop hides them. Details and reproduction in #204.This PR reorders the fetched taxons by the configured code list and filters out disabled ones. Codes that resolve to no enabled taxon are simply skipped, so a list keeps rendering when one of its taxons is disabled or deleted.
Tests: the render test now asserts the configured order is preserved (codes requested in reverse database order), and a new test covers the disabled-taxon filtering. Full
tests/Unitsuite green (183 tests).Same family as #119 (disabled products in grids/carousels), which this PR does not touch.