This repository was archived by the owner on Mar 28, 2022. It is now read-only.
PLAT-11060: Reauthenticate DF loop#103
Merged
Merged
Conversation
If the session expires in the datafeed loop, authentication is going to be attempted again. This is only applied to the DF loop, not globally (this is not actively maintained, doing it globally would require more work). This way the DF loop should not exit once the session expires. In case the bot account has been disabled it will keep retrying forever (again better handling it requires much more work because the authenticate() part is not propagating errors). Ideally exponential backoff should be implemented.
Contributor
Author
|
The package-json update should with the sec vulnerabilities spotted by Github |
thibauult
approved these changes
Jun 24, 2021
symphony-elias
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-11060
Description
PLAT-11060: Reauthenticate inside datafeed loop
If the session expires in the datafeed loop, authentication is going to
be attempted again.
This is only applied to the DF loop, not globally (this is not actively
maintained, doing it globally would require more work). This way the DF
loop should not exit once the session expires.
In case the bot account has been disabled it will keep retrying forever
(again better handling it requires much more work because the authenticate()
part is not propagating errors). Ideally exponential backoff should be
implemented.
Dependencies
N/A
Checklist