This repository was archived by the owner on Mar 28, 2022. It is now read-only.
APP-3330: Fixed regex in SymMessageParser#95
Merged
symphony-elias merged 5 commits intoNov 30, 2020
Conversation
symphony-elias
commented
Nov 26, 2020
andreihincu
previously approved these changes
Nov 27, 2020
andreihincu
left a comment
andreihincu
left a comment
There was a problem hiding this comment.
Much better and cleaner....Great job, @symphony-elias !
symphony-youri
previously approved these changes
Nov 27, 2020
symphony-youri
left a comment
symphony-youri
left a comment
Contributor
There was a problem hiding this comment.
👍 good job on removing the regex
symphony-elias
dismissed stale reviews from symphony-youri and andreihincu
via
82f54f1
symphony-youri
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
APP-3330
Description
Fixed regex in SymMessageParser to avoid ReDOS. Added unit tests.
Checklist