Closed
Conversation
Why?
1. Non-Core CMS's may not have build process in the future.
- So what they use must come from Core-CMS.
2. Adapting to #1 simplifies the CSS of non-Core CMS's.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Jul 22, 2022
Core-CMS 'task/TUP-250--frontera-cms-test': - moved to Core-CMS - loaded from there by Frontera caused by TACC/Core-CMS#518
This was referenced Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Overview
Add CMS stylesheets that Frontera used, and update Frontera to use them from CMS instead.
Why?
Related
causes Task/tup 250 frontera cms test tup-ui#33causes feat: add CSS from Core-Styles & Frontera #518
Changes
Testing
Build the CMS with https://github.com/TACC/tup-cms/pull/3.
No need for
git submodulecommands. No need to symlink Fronterasettings_custom.py.Screenshots
(skipped)