Skip to content

Feat/tup-632: django.cms.picture.css to core-cms#736

Merged
wesleyboar merged 5 commits intomainfrom
feat/tup-632-migrate-cms.picture.css
Nov 2, 2023
Merged

Feat/tup-632: django.cms.picture.css to core-cms#736
wesleyboar merged 5 commits intomainfrom
feat/tup-632-migrate-cms.picture.css

Conversation

@R-Tomas-Gonzalez
Copy link
Copy Markdown
Contributor

Overview

Migrated django.cms.picture.css to core-cms

Related

Changes

  • CSS includes centering images

Testing

  1. Zoom out and make sure image is centered. You can tick off the img.align-center class and see that the images will move to the left of the screen. Also, make sure it is importing from core-cms.css

UI

Before
Screenshot 2023-10-23 at 1 52 16 PM
Without
Screenshot 2023-10-23 at 1 52 42 PM
After
Screenshot 2023-10-23 at 1 51 33 PM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added feature A new feature or replacement of present feature migrate css to core Migration of CSS to Core-CMS or Core-Styles labels Oct 23, 2023
… Now will submit actual change. See line 12 (img.align-center).
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe. Local test is successful. I add a code comment, because the purpose of this "one-liner" code is not intuitive.

@wesleyboar wesleyboar merged commit 9b0951c into main Nov 2, 2023
@wesleyboar wesleyboar deleted the feat/tup-632-migrate-cms.picture.css branch November 2, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature or replacement of present feature migrate css to core Migration of CSS to Core-CMS or Core-Styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants