feat: tup-624: added generics/attributes to demo#244
Merged
wesleyboar merged 4 commits intofeat/tup-463from Oct 13, 2023
Merged
feat: tup-624: added generics/attributes to demo#244wesleyboar merged 4 commits intofeat/tup-463from
wesleyboar merged 4 commits intofeat/tup-463from
Conversation
github-actions
bot
added
the
feature
wesleyboar
requested changes
Oct 13, 2023
Member
wesleyboar
left a comment
wesleyboar
left a comment
There was a problem hiding this comment.
We did this together, so I saw it working. And it's good. But please fix the diff, so I can verify what has changed.
wesleyboar
approved these changes
Oct 13, 2023
wesleyboar
added a commit
that referenced
this pull request
Oct 13, 2023
* style: fix a quote mistake * feat: tup-624: added generics/attributes to demo (#244) * added generics/attributes to demo * added disabled attr pointer-events to generics/attributes --------- Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> * feat: tup-619 c-content-block migration (#245) * feat: tup-610 content-block migration * quick fix, moved import from base to cms * moved import from base to cms * delete dist file for content-block --------- Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> --------- Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add in the data-prefix css for generics/attributes
Related
Changes
added attributes styles
added attributes demo
Testing
Open and Review:
http://localhost:3000/components/detail/attributes
http://localhost:3000/components/detail/c-button--primary
UI