Skip to content

refactor: v3#454

Draft
wesleyboar wants to merge 20 commits intomainfrom
epic/v3
Draft

refactor: v3#454
wesleyboar wants to merge 20 commits intomainfrom
epic/v3

Conversation

@wesleyboar
Copy link
Member

Overview

Fix all the problems with Core-Styles v2.

Important

  • Styles are backwards-compatible.
  • The directory structure is not backwards-compatible.
  • The /dist directory is not committed to GitHub.

Related

Changes

Testing

UI

* feat!: remove dist

* conf!: ignore dist

* feat!: prevent publish if .css in src

Need next to:
- Rename source files to .postcss.
- Deal with demo stylesheets.

* feat: log if no dist found in source

* refactor: optimizations

* refactor: renamed vars

* refactor: renamed source .css files to .postcss

* refactor: move **/*.css source to ../*.postcss

* fix/refactor: load .postcsss not .css

* temp: restore dist (rebuilt) to diff

* revert "conf!: ignore dist" (manually)

* chore: delete & ignore dist (again)

I checked diff with base branch. All good:
- Diff had changes (unexpected).
- Diff changes were rmeoval of demo and outdated files.

* chore: ignore dist

* chore: delete util script

* fix: ignore fractal util file
* test: demo action

* feat: lint dir & worflow to do so, UNTESTED

* fix: lint workflow job step names

* test: lint workflow job name

* config: lint workflow on .css change for epic/v3

* test: build .css files

* config: output paths from repo root not fs root

* fix: delete align.css

* fix: delete admonition.css

* noop: test commit (new line)

* Revert "noop: test commit (new line)"

This reverts commit 88cf542.

* noop: test commit (new line) in a .css file

* Revert "noop: test commit (new line) in a .css file"

This reverts commit d6aa2ca.
@wesleyboar wesleyboar added enhancement Improvements or additions to existing features feature A new feature or replacement of existing feature refactor Re-writes/structures code but retains behavior major An incompatible API change labels Feb 18, 2025
wesleyboar and others added 2 commits March 17, 2026 13:00
## Overview / Changes

- Fix outdated undocumented lint script.
- Fix inaccurate path imports since merging main.

## Related

- cleans up #454
    - as does #603

## Testing

1. `npm run build` - no errors
2. `npm run lint` - no errors

## UI

### `npm run build`

```
Core-Styles-v3 % npm run build

> @tacc/core-styles@3.0.0-alpha.0 build
> npm run build:css && npm run build:demo


> @tacc/core-styles@3.0.0-alpha.0 build:css
> bin/build.js --build-id=$npm_config_build_id

Tagging CSS version as @tacc/core-styles 3.0.0-alpha.0+ | MIT | github.com/TACC/Core-Styles
Creating tokens for v1, v2, v3, ds
Building stylesheet(s)  to /Users/wbomar/Code/TACC/Core-Styles-v3/dist

> @tacc/core-styles@3.0.0-alpha.0 postbuild:css
> rm -rf dist/fonts && cp -r src/lib/fonts dist/fonts


> @tacc/core-styles@3.0.0-alpha.0 prebuild:demo
> rm -rf dist/_utils && cp -r src/lib/_utils dist/_utils


> @tacc/core-styles@3.0.0-alpha.0 build:demo
> fractality build

Fractality version mismatch! Global: 3.0.0-alpha.0 / Local: 1.6.3
✔ Build started...
⚑ Exported 966 of 966 items
✔ Build finished with no errors.
```

### `npm run lint`

```
Core-Styles-v3 % npm run lint

> @tacc/core-styles@3.0.0-alpha.0 lint
> npm run lint:dirs


> @tacc/core-styles@3.0.0-alpha.0 lint:dirs
> bin/only-commit-source.js

No dist files found in source. Ready to publish.
```

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements or additions to existing features feature A new feature or replacement of existing feature major An incompatible API change refactor Re-writes/structures code but retains behavior

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant