Skip to content

refactor(v3): reorganize styles per client library#455

Draft
wesleyboar wants to merge 58 commits intoepic/v3from
epic/v3--reorg
Draft

refactor(v3): reorganize styles per client library#455
wesleyboar wants to merge 58 commits intoepic/v3from
epic/v3--reorg

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 18, 2025

Overview

Moved patterns into directories per client library — Bootstrap 3, Bootstrap 4, Bootstrap 5, Ant, TACC, etc. — and into child directories that mirror the client library's.

Status

  • quality of life
    • support absolute imports
      (to make refactoring easier)
    • use absolute imports
  • user experience
    • group "Bootstrap 3/4/5" into "Bootstrap"
    • group "Django CMS …" into "Django CMS"
      (consider adding alias "TACC/Core-CMS")
    • group "…Docs & M…down" into "Styles for Docs"
  • reorganization
    • Bootstrap
    • (many others)
    • TACC
      move ___.css to ___/___.css
      add context:subdir to ___/config.yml
      change label "(CMS|…) ___" to just "CMS|…"
      • components
      • elements
      • generics
      • objects
      • settings
      • tools
      • trumps

Changes

  • organized Bootstrap patterns like Bootstrap
  • moved patterns into _imports/___ dir for each library
  • moved ___.css to ___/___.css
  • added context:subdir to ___/config.yml
  • added missing demos
  • refactored cross-client patterns to share code
  • added mixins
  • documented docs/upgrade-client.md

Testing

  1. Open every pattern in the demo.
  2. Verify styles are as they were.
  3. Verify organization mirrors client:

UI

2025-07-30

epic v3 reorg 2025-07-30

* feat(djangocms-blog): pagination

* feat(pagination): WIP See `TODO` and `XXX`

- 🚧 bootstrap4 .pagination
    - ✅ default
    - 🐞 tacc (CMS/Portal)
        - UI bugs
        - consider combining
- ✅ djangocms-blog .pagination
- ❌ TACC .c-page
    - deleted out of ignorance
    - must be restored
    - reference provided

* fix(pagination): skin (color, border, outline, …)

- 💡 bootstrap4 .pagination
    - ✅ default
    - ✅ tacc (CMS/Portal)
        - 💡 consider combining
- ✅ djangocms-blog .pagination
- ❌ TACC .c-page
    - deleted out of ignorance
    - must be restored
    - reference provided

* refactor(pagination): link vs link--end

* docs(pagination): TODO @import x-link x-button

* refactor(pagination): __item & __link → vs __…-item & __…-link

* fix(pagination): skipped bootstrap link blue

* chore(pagination): re-order style and remove cruft

* fix(pagination): button (as link) looses width

* refactor(pagination): assume links are <a>

* enhance(pagination): edge cases

* fix(pagination): cms & portal match but are split

* fix(pagination): easy button links & square links

* fix(c-page): restore

* fix(c-page): restore it as it was, no c-pagination

* feat(pagination): tools/x-pagination demo

* fix(pagination): consistent border-radius

- components/c-page
- bootstrap4/pagination
- tools/x-pagination

* fix(pagination): consistent skip/etc links

* refactor(pag…): disabled/active links → modifiers

* enhance(pagination): disabled link for c-page

* fix(pag…): c-page should NOT use button class

* fix(pag…): list too tall, inconsistentent w/ x-…

* enhancepagination): consistent demos

* chore(pagination): mark all demos as ready

* fix(pagination): bootstrap discrepancy
* feat!: bootstrap4 WIP

* fix(v3): nav bootstrap css load bugs

* refactor(v3): Nav: Nav Tabs → Nav: Tabs

* feat(v3): bs4 grid reorg

* conf(v3): move subdir definition to subdir

* feat(v3): distinguish global styles demo/set…/base

* fix(v3): lost col demo styles

* docs(v3): grid belongs in layout

* fix(v3): grid css moved so update core-styles

* docs(v3): move bs4 nav to bs4 components

* docs(v3): figure belongs in content

* docs(v3): order bs4 categogories

* refactor(v3): move remaining bs4 patterns

* docs(v3): match bootstrap 4 pattern naming

* enhance(v3): hack to support tacc btns in modals

* docs(v3): extra note about TACC modal button hack

* refactor(v3): move all bs4 .postcss into child dir

* fix(v3): user expects nav-tabs.css not tabs.css
@wesleyboar wesleyboar changed the title Epic/v3 reorg refactor(v3): reorganize styles per client library Feb 18, 2025
Not a fix, because nothing was broken.

Nothing broke, because Bootstrap4 is included in `core-styles.base.css`.

Required in Bootstrap 3, because Boostrap 3 relies on _preview.css to load pattern stylesheet.
@wesleyboar wesleyboar added major An incompatible API change feature A new feature or replacement of existing feature labels Feb 18, 2025
wesleyboar and others added 24 commits March 4, 2025 18:01
TODO: Rename component to match Bootstrap 5 naming
I dunno. They work now. They are consistent. They are redundant. I am tired. I am done.
## Overview

Import path fix since latest merge of `epic/v3`.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature or replacement of existing feature major An incompatible API change refactor Re-writes/structures code but retains behavior

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant