feat(tup-cms): svg decals for layered images#168
Conversation
wesleyboar
changed the title
wesleyboar
changed the title
And make it more likely to show up all the time for any browser.
Some apps fail to read from CMS page (they show URL), so I manually set: - portal - portal debug Some app templates can read title from CMS page at same URL: - list Some pages cannot read form CMS because we won't create a page for each: - read
taoteg
left a comment
taoteg
left a comment
There was a problem hiding this comment.
Looks good.
Do we care about the unused assignment annotation warnings in Sidebar.tsk, ProjectDetails.tsx and Dashboard.tsx?
They appear to be unchanged, but flagged files in the PR.
Approving regardless.
|
@taoteg Annotation are unrelated. We care, but I have active work on tup-ui. When someone get's a cycle, someone will commit or open a PR will fix those. |
|
@taoteg Oh, never mind. There's some odd stuff in this diff. I must have accidentally merged |
wesleyboar
changed the title
wesleyboar
changed the title
|
Fixed. And I added some more symbols in the SVG. |
|
Cleaned up confusing comment. Designer has tested, and it works.* * They want to do more tricky things (different styles for different shapes within the same symbol), that ideally use inline SVG, but I gave two options that don't require that (a: layer two Icons; b: use fill and add stroke in one symbol in a way that works with one set of styles). I'll revisit Core-CMS if I want to go with an inline SVG solution. |
3 participants
Overview & Changes
Allow designers to add TACC-specific decals to images.
Related
Changes
Testing & UI
icon.on.tacc.mov
Notes
I accidentally merged
dev/tup-cmsinto here. I fixed it by merging #167 intomain, thenmainintodev/tup-cmsanddev/tup-cmsinto here (again). VCS is fun.Known Issues
Video
djangocms_icon.dual.svg.set.bug.mov