Skip to content

feat: tup-624: added generics/attributes to demo #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesleyboar merged 3 commits into from
Oct 16, 2023
Merged

feat: tup-624: added generics/attributes to demo #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
605ecac
feat: tup-624: added generics/attributes to demo
R-Tomas-Gonzalez Oct 12, 2023
aa077ce
migrated rest of attributes.css to core-styles
R-Tomas-Gonzalez Oct 12, 2023
0ce028f
removed unnecessary comments in css file for c-button
R-Tomas-Gonzalez Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ...ms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles/components/c-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,4 @@ main > .container .c-button--is-active {

/* FAQ: Design shows 10px font */
font-size: var(--global-font-size--x-small);
}

/* TODO: Remove from c-button (once it becomes redundant there) */
/* FAQ: This is now added in generics/attributes.css */
/*
[disabled] {
pointer-events: none;
}
*/
}
13 changes: 0 additions & 13 deletions ...ms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles/generics/attributes.css
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/tup-cms.for-core-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* … */

/* GENERICS */
@import url("./for-core-styles/generics/attributes.css") layer(base);
/* … */

/* ELEMENTS */
/* … */
Expand Down
10 changes: 0 additions & 10 deletions apps/tup-ui/src/main.global.for-core-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,6 @@ hr {
height: 16px;
}

/* TODO: Remove this after:
0. attributes.css is migrated to Core-Styles
1. attributes.css is loaded by Portal */
[data-prefix]::before {
display: inline-block;
content: attr(data-prefix);
margin-right: 0.25ch;
text-transform: none;
}

/* TODO: Remove this after:
0. CEP v2 colors are removed from Core-Styles settings/color--portal */
#page-portal main /* i.e. global-safe :root */ {
Expand Down