Add balance resource and todos by kirahsapong · Pull Request #212 · TBD54566975/tbdex-js

kirahsapong · 2024-03-25T19:18:59Z

closes #138

adds Balance resource and protocol tests
adds client getBalance method and tests
adds server GET /balance endpoint, handlers and tests

changeset-bot · 2024-03-25T19:19:02Z

⚠️ No Changeset found

Latest commit: 7716e0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-03-25T19:21:04Z

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 3

@tbdex/protocol

Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

Project entry file: packages/http-server/src/main.ts

📄 File: packages/http-server/src/http-server.ts
⚠️ `extractor:ae-unresolved-link`: The `@link` reference could not be resolved: The package "`@tbdex`/http-server" does not have an export "InMemoryOfferingsApi" #L49
⚠️ `extractor:ae-unresolved-link`: The `@link` reference could not be resolved: The package "`@tbdex`/http-server" does not have an export "InMemoryExchangesApi" #L49
⚠️ `extractor:ae-unresolved-link`: The `@link` reference could not be resolved: The package "`@tbdex`/http-server" does not have an export "InMemoryBalancesApi" #L49

TBDocs Report Updated at 2024-03-29T15:50:25Z 7716e0a

codecov · 2024-03-25T19:22:17Z

Codecov Report

Merging #212 (77954d8) into main (529b37a) will decrease coverage by 1.76%.
The diff coverage is 35.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   93.53%   91.77%   -1.76%     
==========================================
  Files          39       40       +1     
  Lines        3141     3236      +95     
  Branches      356      357       +1     
==========================================
+ Hits         2938     2970      +32     
- Misses        203      266      +63

Components	Coverage Δ
protocol	`91.06% <35.71%> (-3.22%)`	⬇️
http-client	`94.83% <ø> (ø)`
http-server	`91.05% <ø> (ø)`

codecov-commenter · 2024-03-27T22:40:33Z

Codecov Report

Merging #212 (818ce7a) into main (6dea4d9) will increase coverage by 0.11%.
The diff coverage is 94.46%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   92.91%   93.03%   +0.11%     
==========================================
  Files          39       42       +3     
  Lines        3104     3386     +282     
  Branches      344      374      +30     
==========================================
+ Hits         2884     3150     +266     
- Misses        220      236      +16

Components	Coverage Δ
protocol	`93.32% <95.37%> (+0.10%)`	⬆️
http-client	`95.27% <100.00%> (+0.34%)`	⬆️
http-server	`90.87% <91.91%> (+0.16%)`	⬆️

packages/http-server/src/http-server.ts

packages/http-server/src/request-handlers/get-balances.ts

packages/http-server/tests/get-balances.spec.ts

+  it('returns 401 if bearer token is missing from the Authorization header', async () => {
+    const resp = await fetch('http://localhost:8000/balances', {
+      headers: {
+        'Authorization': 'Not well formatted token'


packages/http-server/tests/get-balances.spec.ts

+  it('returns 401 if the bearer token is malformed in the Authorization header', async () => {
+    const resp = await fetch('http://localhost:8000/balances', {
+      headers: {
+        'Authorization': 'Bearer MALFORMED'


packages/http-server/src/http-server.ts

+      this.api.get('/balances', (req, res) =>
+        getBalances(req, res, {
+          callback: this.callbacks['getBalances'],
+          balancesApi,
+          pfiDid,
+        })


KendallWeihe

two open comments but neither are blockers

awesome work here!

packages/protocol/src/types.ts

packages/http-server/src/http-server.ts

packages/protocol/build/compile-validators.js

packages/protocol/tests/balance.spec.ts

tbdex

packages/http-server/src/http-server.ts

* main: Refresh offerings test vector (#218) updating parse close vector with success field (#220) Add balance resource and todos (#212)

kirahsapong force-pushed the feat/add-balance-resource branch from 14c8e0a to 5af95dd Compare March 28, 2024 16:51

kirahsapong marked this pull request as ready for review March 28, 2024 19:24

kirahsapong requested review from KendallWeihe, diehuxx, jiyoonie9, michaelneale, mistermoe and phoebe-lew as code owners March 28, 2024 19:24

kirahsapong mentioned this pull request Mar 28, 2024

add balance vector TBD54566975/tbdex#301

Merged

KendallWeihe reviewed Mar 28, 2024

View reviewed changes

packages/http-server/src/http-server.ts Outdated Show resolved Hide resolved

KendallWeihe reviewed Mar 28, 2024

View reviewed changes

packages/http-server/src/request-handlers/get-balances.ts Outdated Show resolved Hide resolved

kirahsapong force-pushed the feat/add-balance-resource branch from 8a35046 to 3da75c2 Compare March 28, 2024 21:33

github-advanced-security bot found potential problems Mar 28, 2024

View reviewed changes

KendallWeihe approved these changes Mar 28, 2024

View reviewed changes

packages/protocol/src/types.ts Outdated Show resolved Hide resolved

packages/http-server/src/http-server.ts Outdated Show resolved Hide resolved

jiyoonie9 reviewed Mar 29, 2024

View reviewed changes

packages/protocol/build/compile-validators.js Outdated Show resolved Hide resolved

jiyoonie9 reviewed Mar 29, 2024

View reviewed changes

packages/protocol/tests/balance.spec.ts Outdated Show resolved Hide resolved

jiyoonie9 reviewed Mar 29, 2024

View reviewed changes

tbdex Show resolved Hide resolved

jiyoonie9 approved these changes Mar 29, 2024

View reviewed changes

jiyoonie9 mentioned this pull request Mar 29, 2024

Feat/add get balance TBD54566975/tbdex-swift#77

Merged

diehuxx reviewed Mar 29, 2024

View reviewed changes

packages/http-server/src/http-server.ts Outdated Show resolved Hide resolved

diehuxx approved these changes Mar 29, 2024

View reviewed changes

Kirah Sapong added 5 commits March 29, 2024 08:46

add balance resource and todos

4f20445

update validtor to cjs

976134f

add client get balances method

fe16f6b

resolve todos

0091c2e

add client and vector tests

0bfb1e4

Kirah Sapong added 9 commits March 29, 2024 08:46

bump tbdex submodule

ba7e293

add todos

2c26999

add optional balances endpoint

43e03ab

update comments

4a3b88e

update test vectors spec

7872b9f

add authz to balances endpoint

423cae9

remove paymentMethodKind enum

9886061

update httpServer opts

dacee44

bump spec, update syntax, remove xits

e221206

kirahsapong force-pushed the feat/add-balance-resource branch from 818ce7a to e221206 Compare March 29, 2024 15:46

remove cjs

7716e0a

kirahsapong merged commit 7edf704 into main Mar 29, 2024

kirahsapong deleted the feat/add-balance-resource branch March 29, 2024 16:00

diehuxx pushed a commit that referenced this pull request Mar 30, 2024

Merge branch 'main' into rfq-private-salt

a27afd2

* main: Refresh offerings test vector (#218) updating parse close vector with success field (#220) Add balance resource and todos (#212)

kirahsapong mentioned this pull request Mar 31, 2024

Implement GetBalance client call and server endpoint TBD54566975/tbdex-kt#217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add balance resource and todos#212

Add balance resource and todos#212
kirahsapong merged 15 commits intomainfrom
feat/add-balance-resource

kirahsapong commented Mar 25, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 25, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 25, 2024 •

edited

Loading

Uh oh!

codecov bot commented Mar 25, 2024

Uh oh!

codecov-commenter commented Mar 27, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

KendallWeihe left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kirahsapong commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@tbdex/protocol

@tbdex/http-client

@tbdex/http-server

Uh oh!

codecov bot commented Mar 25, 2024

Codecov Report

Uh oh!

codecov-commenter commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

KendallWeihe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kirahsapong commented Mar 25, 2024 •

edited

Loading

changeset-bot bot commented Mar 25, 2024 •

edited

Loading

github-actions bot commented Mar 25, 2024 •

edited

Loading

codecov-commenter commented Mar 27, 2024 •

edited

Loading