Add Hedgedoc authentication#32
Closed
JJ-8 wants to merge 1 commit into
Closed
Conversation
When a new account is created, CTFNote now tries to register the user to Hedgedoc. After that, the user will be automatically authenticated to Hedgedoc when logging in. The slug and password of the user are used for registering. Only new accounts are registered to Hedgedoc. However, on every log in CTFNote tries to authenticate the user to Hedgedoc. This does not cause an error. The benefit of authenticating is that the cursor of the user shows the username/slug and changes by users are shown by Hedgedoc. The slug is used instead of the username because the slug never changes for a user. If the username was used and it changes, then authentication will always fail on login. This feature can be disabled by the env variable MD_AUTH.
Collaborator
Author
|
You can register manually to the Hedgedoc instance with the correct email and same password used in CTFNote in order to make Hedgedoc authentication working for existing accounts. |
Member
|
Thats great ! we are working on a backend rework right now, but I will add this patch I think it's a cool feature Thanks for the support! |
JJ-8
pushed a commit
to JJ-8/CTFNote
that referenced
this pull request
May 31, 2021
When a new account is created, CTFNote now tries to register the user to Hedgedoc. After that, the user will be automatically authenticated to Hedgedoc when logging in. The slug and password of the user are used for registering. The benefit of authenticating is that the cursor of the user shows the username and changes by users are shown by Hedgedoc. No new URL is required, because the MD create url is used for building the URL. Follow up of TFNS#32
Collaborator
Author
|
Closed due to inactivity and follow up |
JJ-8
added a commit
to woutvanderploeg/CTFNote
that referenced
this pull request
Jun 17, 2023
0 fix illegal dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new account is created, CTFNote now tries to register the user to Hedgedoc. After that, the user will be automatically authenticated to Hedgedoc when logging in. The slug and password of the user are used for registering.
Only new accounts are registered to Hedgedoc. However, on every log in CTFNote tries to authenticate the user to Hedgedoc. This does not cause an error.
The benefit of authenticating is that the cursor of the user shows the username/slug and changes by users are shown by Hedgedoc.
The slug is used instead of the username because the slug never changes for a user. If the username was used and it changes, then authentication will always fail on login.
This feature can be disabled by the env variable MD_AUTH.
No new URL is required, because the MD create url is used for building the URL.