Skip to content

[REFACTOR] 4차 QA 진행 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbqks529 merged 16 commits into from
Oct 26, 2025
Merged

[REFACTOR] 4차 QA 진행 #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
008cd5b
[chore]: 배포 버전 변경
Nico1eKim Sep 30, 2025
e6e729d
Merge branch 'develop' of https://github.com/THIP-TextHip/THIP-Android
Nico1eKim Oct 9, 2025
513df39
[release]: ga 연결 문제 해결 (#144)
Nico1eKim Oct 9, 2025
d635718
[refactor]: 프로필 팔로워 수 오류 해결 (#144)
Nico1eKim Oct 9, 2025
31b87de
[refactor]: 회원가입 칭호 선택 스크롤 문제 해결 (#144)
Nico1eKim Oct 9, 2025
e312f69
[refactor]: 화면 전환 효과 없애기 (#144)
Nico1eKim Oct 9, 2025
d69a23e
[refactor]: 모임, 검색 상단바 높이 다름 해결 (#144)
Nico1eKim Oct 9, 2025
428dce8
[refactor]: 댓글 드롭다운 열렸을 때 뒤로가기 누르면 드롭다운 닫히게 수정 (#144)
Nico1eKim Oct 9, 2025
f6cecec
[refactor]: 내 프로필 팔로워 수 오류 해결 (#144)
Nico1eKim Oct 9, 2025
7f2c9e7
[refactor]: 모임 투표 생성 시 제목 가이드 멘트 수정 (#144)
Nico1eKim Oct 9, 2025
409dbab
[refactor]: 사용자 검색 아이콘 수정 (#144)
Nico1eKim Oct 9, 2025
e7c9ea7
Merge branch 'develop' of https://github.com/THIP-TextHip/THIP-Androi…
Nico1eKim Oct 24, 2025
c2d00bb
[refactor]: 내 모임방에 완료방 추가 (#144)
Nico1eKim Oct 24, 2025
9aa6eda
[refactor]: 내 모임방에서 완료된 모임방 날짜 삭제, 클릭하면 완료된 모임방으로 이동하도록 수정 (#144)
Nico1eKim Oct 24, 2025
2864d07
[refactor]: 완료된 모임방 없애기 (#144)
Nico1eKim Oct 24, 2025
3574a70
[fix]: 버전 관리 수정 (#144)
Nico1eKim Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
<uses-permission android:name="com.google.android.gms.permission.AD_ID"
tools:ignore="AdvertisingIdPolicy" />
Comment on lines +7 to +8

@coderabbitai coderabbitai Bot Oct 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

광고 ID 권한 추가가 PR 목표와 일치하지 않습니다.

이 PR의 목표는 프로필 팔로워 수 수정, 가입 중 제목 스크롤 가능 설정, 미팅룸 사용성 개선입니다. 그러나 com.google.android.gms.permission.AD_ID 권한 추가는 이러한 목표와 관련이 없어 보입니다.

추가 고려사항:

  • tools:ignore="AdvertisingIdPolicy"의 사용은 린트 경고 억제로 보여, 비즈니스 목적 없이 권한이 추가되었을 가능성을 시사합니다.
  • 광고 ID는 개인정보보호 및 규정준수(GDPR/CCPA)와 관련된 민감한 권한입니다.
  • 이 권한을 사용하는 코드가 이 PR에서 추가되었는지, 그리고 개인정보보호정책이 업데이트되었는지 확인이 필요합니다.

이 권한 추가의 목적을 설명해주시고, 다음을 확인하도록 요청드립니다:

  1. 이 권한이 실제로 PR의 변경사항과 관련이 있는지 여부
  2. 이 권한을 사용하는 코드가 추가되었는지 여부
  3. 앱의 개인정보보호정책이 광고 ID 사용에 대해 업데이트되었는지 여부
  4. 의도치 않은 변경이라면, 별도 PR로 분리하는 것을 권장합니다.

다음 스크립트를 실행하여 광고 ID 사용 여부를 확인할 수 있습니다:

🏁 Script executed:

#!/bin/bash
# Description: Search for Google Advertising ID usage in the codebase

# Search for AD_ID permission usage
rg -i "ad_id|advertising.*id|google.*ad" --type kotlin --type java -C 3

Length of output: 0

🏁 Script executed:

#!/bin/bash
# Search for AdvertisingIdPolicy mentions
rg -i "advertisingidpolicy" -C 3

# Search for Google Play Services imports
rg "com\.google\.android\.gms" --type kotlin --type java -C 2

# Search for any references in manifest to services/activities that might use ad ID
rg "service|activity|receiver" app/src/main/AndroidManifest.xml -C 2

Length of output: 3953

사용되지 않는 광고 ID 권한을 제거해야 합니다.

광고 ID 권한(com.google.android.gms.permission.AD_ID)이 추가되었으나 전체 코드베이스에서 어떤 곳에서도 사용되지 않고 있습니다. 검색 결과:

  • 광고 ID 관련 코드: 0건
  • 광고 ID API 임포트: 0건
  • Google Play Services 의존성: play-services-auth만 있음 (Google 로그인용)
  • 사용 중인 GMS 기능: 인증(GoogleSignIn), Firebase 메시징만 해당

tools:ignore="AdvertisingIdPolicy"는 사용되지 않는 권한에 대한 린트 경고를 억제하기 위한 것으로 보입니다.

조치:

  1. AndroidManifest.xml의 AD_ID 권한 선언 제거 (7-8줄)
  2. tools:ignore 속성도 함께 제거

이는 불필요한 개인정보보호 민감 권한을 앱에서 제거하는 것으로, 앱 스토어 규정 준수와 사용자 개인정보 보호 차원에서 권장됩니다.

🤖 Prompt for AI Agents 
In app/src/main/AndroidManifest.xml around lines 7-8, remove the unused AD_ID
permission declaration and its tools:ignore attribute: delete the
<uses-permission android:name="com.google.android.gms.permission.AD_ID"
tools:ignore="AdvertisingIdPolicy" /> entry so the manifest no longer requests
the advertising ID permission; after removal, rebuild and verify no references
to AD_ID remain and lint no longer needs the suppressed AdvertisingIdPolicy
warning.


<application
android:name=".ThipApplication"
Expand Down
8 changes: 7 additions & 1 deletion app/src/main/java/com/texthip/thip/MainActivity.kt
View file
Open in desktop

@rbqks529 rbqks529 Oct 26, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드는 혹시 어떻게 로직이 수정된건가용

@Nico1eKim Nico1eKim Oct 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 화면 전환할 때 들어간 애니메이션 효과를 없앤겁니둣

Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.activity.enableEdgeToEdge
import androidx.activity.result.contract.ActivityResultContracts
import androidx.compose.animation.EnterTransition
import androidx.compose.animation.ExitTransition
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
import androidx.compose.runtime.LaunchedEffect
Expand Down Expand Up @@ -177,7 +179,11 @@ fun RootNavHost(

NavHost(
navController = navController,
startDestination = CommonRoutes.Splash
startDestination = CommonRoutes.Splash,
enterTransition = { EnterTransition.None },
exitTransition = { ExitTransition.None },
popEnterTransition = { EnterTransition.None },
popExitTransition = { ExitTransition.None }
) {
// --- 인증 관련 화면들 ---
authNavigation(
Expand Down
25 changes: 14 additions & 11 deletions app/src/main/java/com/texthip/thip/ui/common/cards/CardItemRoom.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ fun CardItemRoom(
imageUrl: String? = null,
hasBorder: Boolean = false,
isSecret: Boolean? = null,
isExpired: Boolean = false,
onClick: () -> Unit = {}
) {
Card(
Expand Down Expand Up @@ -161,19 +162,21 @@ fun CardItemRoom(
}
}
}
endDate?.let {
Spacer(modifier = Modifier.height(5.dp))
if (!isExpired) {
endDate?.let {
Spacer(modifier = Modifier.height(5.dp))

Text(
text = endDate
+ if (isRecruiting) stringResource(
R.string.card_item_end
) else stringResource(R.string.card_item_finish),
Text(
text = endDate
+ if (isRecruiting) stringResource(
R.string.card_item_end
) else stringResource(R.string.card_item_finish),

color = if (isRecruiting) colors.Red else colors.Grey01,
style = typography.menu_sb600_s12_h20,
maxLines = 1
)
color = if (isRecruiting) colors.Red else colors.Grey01,
style = typography.menu_sb600_s12_h20,
maxLines = 1
)
}
}
}
}
Expand Down
16 changes: 9 additions & 7 deletions app/src/main/java/com/texthip/thip/ui/common/topappbar/LogoTopAppBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import com.texthip.thip.ui.theme.ThipTheme.colors
@Composable
fun LogoTopAppBar(
modifier: Modifier = Modifier,
leftIcon: Painter,
leftIcon: Painter? = null,
hasNotification: Boolean,
onLeftClick: () -> Unit = {},
onRightClick: () -> Unit = {}
Expand Down Expand Up @@ -56,12 +56,14 @@ fun LogoTopAppBar(
horizontalArrangement = Arrangement.spacedBy(20.dp),
verticalAlignment = Alignment.CenterVertically
) {
Icon(
painter = leftIcon,
contentDescription = "Left Icon",
tint = Color.Unspecified,
modifier = Modifier.clickable { onLeftClick() }
)
leftIcon?.let {
Icon(
painter = it,
contentDescription = "Left Icon",
tint = Color.Unspecified,
modifier = Modifier.clickable { onLeftClick() }
)
}
Icon(
painter = rightIcon,
contentDescription = "Right Icon",
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/com/texthip/thip/ui/feed/component/FeedSubscribelistBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import com.texthip.thip.ui.theme.ThipTheme.typography
@Composable
fun FeedSubscribeBarlist(
modifier: Modifier = Modifier,
followerNum: Int = 0,
followerProfileImageUrls: List<String>,
onClick: () -> Unit
) {
Expand All @@ -59,7 +60,8 @@ fun FeedSubscribeBarlist(
color = colors.White
)
) {
append(stringResource(R.string.thip_num, followerProfileImageUrls.size)) }
append(stringResource(R.string.thip_num, followerNum))
}
withStyle(
style = SpanStyle(
color = colors.Grey
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/texthip/thip/ui/feed/screen/FeedMyScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ fun FeedMyContent(
Spacer(modifier = Modifier.height(16.dp))
FeedSubscribeBarlist(
modifier = Modifier.padding(horizontal = 20.dp),
followerProfileImageUrls = userInfo.latestFollowerProfileImageUrls
?: emptyList(),
followerNum = userInfo.followerCount,
followerProfileImageUrls = userInfo.latestFollowerProfileImageUrls,
onClick = { onNavigateToSubscriptionList(userInfo.creatorId) }
)
Spacer(modifier = Modifier.height(40.dp))
Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/com/texthip/thip/ui/feed/screen/FeedOthersScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ fun FeedOthersContent(
Spacer(modifier = Modifier.height(16.dp))
FeedSubscribeBarlist(
modifier = Modifier.padding(horizontal = 20.dp),
followerNum = userInfo.followerCount,
followerProfileImageUrls = userInfo.latestFollowerProfileImageUrls,
onClick = { onNavigateToSubscriptionList(userInfo.creatorId) }
)
Expand Down
39 changes: 0 additions & 39 deletions app/src/main/java/com/texthip/thip/ui/group/done/mock/MyRoomCardData.kt
View file
Open in desktop

This file was deleted.

199 changes: 0 additions & 199 deletions app/src/main/java/com/texthip/thip/ui/group/done/screen/GroupDoneScreen.kt
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions app/src/main/java/com/texthip/thip/ui/group/done/viewmodel/GroupDoneUiState.kt
View file
Open in desktop

This file was deleted.

Loading