Skip to content

[chore] 무중단 배포 도입#147

Merged
buzz0331 merged 4 commits into
developfrom
chore/#144-unstoppable-cd
Aug 5, 2025
Merged

[chore] 무중단 배포 도입#147
buzz0331 merged 4 commits into
developfrom
chore/#144-unstoppable-cd

Conversation

@buzz0331

@buzz0331 buzz0331 commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

#️⃣ 연관된 이슈

closes #144

📝 작업 내용

cd에서 deploy.sh를 실행해서 blue-green 무중단 배포를 도입했습니다.

📸 스크린샷

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

📌 PR 진행 시 이러한 점들을 참고해 주세요

* P1 : 꼭 반영해 주세요 (Request Changes) - 이슈가 발생하거나 취약점이 발견되는 케이스 등
* P2 : 반영을 적극적으로 고려해 주시면 좋을 것 같아요 (Comment)
* P3 : 이런 방법도 있을 것 같아요~ 등의 사소한 의견입니다 (Chore)

Summary by CodeRabbit

  • 새로운 기능

    • 시스템 모니터링 및 관리 기능 제공을 위한 Actuator 기능이 추가되었습니다.
  • 버그 수정

    • JWT 인증 필터의 동작에는 변화가 없으나, 코드상의 불필요한 세미콜론이 수정되었습니다.
  • 보안

    • 인증이 필요 없는 URL 목록이 축소되어, 테스트 및 데모 엔드포인트 접근이 제한되었습니다.
  • 배포

    • 배포 과정에서 블루-그린 배포 방식이 적용되었습니다.
  • 기타

    • deploy.sh 파일이 Git 추적 대상에서 제외되었습니다.

@buzz0331 buzz0331 self-assigned this Aug 5, 2025
@coderabbitai

coderabbitai Bot commented Aug 5, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

배포 자동화 GitHub Actions 워크플로우에서 기존의 Docker Compose 기반 컨테이너 중지 및 이미지 정리, 재시작 명령을 주석 처리하고, 대신 새로운 블루-그린 배포 스크립트(deploy.sh) 실행 단계가 추가되었습니다. 그 외에 .gitignoredeploy.sh가 추가되고, build.gradle에 Spring Boot Actuator 의존성이 포함되었습니다. 보안 설정에서는 화이트리스트 URL이 축소되었습니다.

Changes

Cohort / File(s) Change Summary
CD Workflow 변경
.github/workflows/cd-workflow-dev.yml
기존 Docker Compose 명령 주석 처리, blue-green 배포 스크립트(deploy.sh) 실행 단계 추가
Git Ignore 업데이트
.gitignore
deploy.sh 파일을 git 무시 목록에 추가
Actuator 의존성 추가
build.gradle
Spring Boot Actuator 의존성 추가
JWT 필터 문법 수정
src/main/java/konkuk/thip/common/security/filter/JwtAuthenticationFilter.java
shouldNotFilter 반환문에 불필요한 세미콜론 추가 (로직 영향 없음)
보안 화이트리스트 축소
src/main/java/konkuk/thip/config/SecurityConfig.java
인증 예외 URL 화이트리스트에서 테스트/데모 엔드포인트 다수 제거, /actuator/health 추가

Sequence Diagram(s)

sequenceDiagram
    participant GitHubActions
    participant Server
    participant DeployScript

    GitHubActions->>Server: Pull new Docker image
    GitHubActions->>Server: Run deploy.sh (blue-green deployment)
    Server->>DeployScript: Execute blue-green deployment logic
    DeployScript-->>Server: Deployment complete
    Server->>GitHubActions: List Docker containers
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective Addressed Explanation
무중단 배포 도입 (blue-green 배포 적용) (#144)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Spring Boot Actuator 의존성 추가 (build.gradle) 무중단 배포와 직접적 연관이 명확하지 않음. 서비스 헬스체크용으로 추정되나, 명시적 요구사항에는 없음.
보안 화이트리스트 URL 축소 (src/main/java/konkuk/thip/config/SecurityConfig.java) 배포 방식 변경과 직접적 연관 없음. 인증 정책 변경은 본 이슈의 범위를 벗어남.
JWT 필터 세미콜론 추가 (src/main/java/konkuk/thip/common/security/filter/JwtAuthenticationFilter.java) 문법적 변경이나, 무중단 배포와는 무관함.

Poem

파란빛, 초록빛, 서버 춤을 추네
deploy.sh로 무중단의 꿈을 꾸네
Actuator로 건강 체크,
화이트리스트는 더 깔끔하게!
토끼는 기뻐 깡총깡총,
배포의 밤에도 걱정 없네!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08af9ad and 07be6d9.

📒 Files selected for processing (5)
  • .github/workflows/cd-workflow-dev.yml (1 hunks)
  • .gitignore (1 hunks)
  • build.gradle (1 hunks)
  • src/main/java/konkuk/thip/common/security/filter/JwtAuthenticationFilter.java (1 hunks)
  • src/main/java/konkuk/thip/config/SecurityConfig.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/#144-unstoppable-cd

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@buzz0331 buzz0331 merged commit eaccdd6 into develop Aug 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[THIP2025-208] [chore] 무중단 배포 도입

1 participant