[hotfix] 모임홈 진행중인 내모임방 조회 시 책 제목이 아닌 방제목 반환 하도록 수정 #187
Merged
Conversation
|
Warning Rate limit exceeded@hd0rable has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 4 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Walkthrough참여 중인 모임 홈 조회 응답에서 제목 필드를 책 제목에서 방 제목으로 변경하고, 해당 쿼리 프로젝션을 book.title에서 room.title로 수정했습니다. 또한 memberCount 집계를 서브쿼리 대신 room.memberCount 필드 사용으로 대체했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller as RoomController
participant Repo as RoomQueryRepository
participant DB
Client->>Controller: GET /home/joined-rooms
Controller->>Repo: findHomeJoinedRooms(userId)
Repo->>DB: SELECT room.title, room.member_count, book.image_url, user_percentage ...
DB-->>Repo: rows
Repo-->>Controller: DTO(roomTitle, memberCount, bookImageUrl, userPercentage)
Controller-->>Client: RoomGetHomeJoinedListResponse
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test Results374 tests 374 ✅ 32s ⏱️ Results for commit f64ba23. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit