[refactor] DateUtil 합치기 (#55)#60
Merged
Merged
Conversation
Walkthrough
Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant RoomQueryRepositoryImpl
participant DateUtil
Client->>RoomQueryRepositoryImpl: 날짜 관련 요청
RoomQueryRepositoryImpl->>DateUtil: formatAfterTime(LocalDate)
DateUtil-->>RoomQueryRepositoryImpl: 남은 시간 문자열 반환
RoomQueryRepositoryImpl-->>Client: 결과 반환
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/konkuk/thip/common/util/DateUtil.java (1)
22-43: 새로운 메서드 추가가 적절하게 구현되었습니다.
formatAfterTime메서드의 로직은 올바르게 구현되었습니다. 다만 몇 가지 개선사항을 제안드립니다:
- 과거 날짜 처리: 현재 "??" 반환값이 사용자에게 명확하지 않을 수 있습니다.
- 문자열 일관성: 반환 문자열에 공백이 포함되어 있는데, 기존
formatLastActivityTime메서드와 일관성을 확인해주세요.- if (d.isNegative() || d.isZero()) { - return "??"; - } + if (d.isNegative() || d.isZero()) { + return "마감됨"; + }그리고 반환 문자열에서 공백 제거를 고려해보세요:
- return days + "일 뒤 "; - return hours + "시간 뒤 "; - return minutes + "분 뒤 "; + return days + "일 뒤"; + return hours + "시간 뒤"; + return minutes + "분 뒤";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/main/java/konkuk/thip/common/util/DateUtil.java(2 hunks)src/main/java/konkuk/thip/common/util/DateUtilsss.java(0 hunks)src/main/java/konkuk/thip/room/adapter/out/persistence/RoomQueryRepositoryImpl.java(2 hunks)
💤 Files with no reviewable changes (1)
- src/main/java/konkuk/thip/common/util/DateUtilsss.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
src/main/java/konkuk/thip/room/adapter/out/persistence/RoomQueryRepositoryImpl.java (2)
11-11: import 문이 올바르게 업데이트되었습니다.
DateUtilsss에서DateUtil로의 import 변경이 적절합니다.
99-99: 완료:DateUtilsss참조 제거 확인됨
DateUtil.formatAfterTime호출로 메서드 업데이트가 올바르게 적용되었습니다.rg및fd검색 결과, Java 파일 내에DateUtilsss참조 및 파일이 더 이상 존재하지 않음을 확인했습니다.
This was referenced Jul 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit
신규 기능
버그 수정