Conversation
브랜치 히스토리 동기화: main -> develop
fix: 로그인 인가방식 수정
|
Caution Review failedThe pull request is closed. Walkthroughpackage.json에 react-cookie(^8.0.1) 의존성이 추가되었고, SignupGenre 컴포넌트에서 토큰 획득 로직이 react-cookie 기반의 동기 방식으로 변경되었습니다. 서버 측 쿠키 검증(fetch /users/me)은 제거되었으며, 실패 시 document.cookie 기반의 폴백 파싱이 유지됩니다. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant SG as SignupGenre.tsx
participant RC as react-cookie
participant API as apiClient
U->>SG: Next 클릭
SG->>RC: Authorization 쿠키 조회
alt 쿠키 있음
SG->>API: Authorization 헤더 설정
SG->>API: 이후 가입 진행(요청)
else 쿠키 없음
SG->>SG: document.cookie 폴백 파싱
alt 토큰 발견
SG->>API: 헤더 설정 후 진행
else 미발견
SG-->>U: 토큰 없음 처리(중단/알림)
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이하동일
Summary by CodeRabbit
Refactor
Chores