Skip to content

develp branch 작업내용 머지 : develop -> main#98

Merged
heeeeyong merged 3 commits into
mainfrom
develop
Aug 12, 2025
Merged

develp branch 작업내용 머지 : develop -> main#98
heeeeyong merged 3 commits into
mainfrom
develop

Conversation

@heeeeyong

@heeeeyong heeeeyong commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

이하동일

Summary by CodeRabbit

  • Refactor

    • 회원가입 단계에서 쿠키 기반 인증 토큰 인식 방식을 개선하여 처리 속도와 안정성을 향상했습니다.
    • 토큰 인식 실패 시의 예외 처리와 로깅을 정비해 실패 원인 파악이 쉬워졌습니다.
    • 불필요한 서버 검증 단계를 제거해 흐름이 더 간결해졌습니다.
  • Chores

    • 쿠키 관리 강화를 위해 react-cookie 의존성을 추가했습니다.

@coderabbitai

coderabbitai Bot commented Aug 12, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

package.json에 react-cookie(^8.0.1) 의존성이 추가되었고, SignupGenre 컴포넌트에서 토큰 획득 로직이 react-cookie 기반의 동기 방식으로 변경되었습니다. 서버 측 쿠키 검증(fetch /users/me)은 제거되었으며, 실패 시 document.cookie 기반의 폴백 파싱이 유지됩니다.

Changes

Cohort / File(s) Summary
Dependency update
package.json
dependencies에 react-cookie@^8.0.1 추가
Signup genre page logic update
src/pages/signup/SignupGenre.tsx
useCookies 도입으로 Authorization 쿠키 동기 조회, 서버 검증 fetch 제거, handleNextClick에서 동기 토큰 처리 및 기존 document.cookie 폴백 유지, 로깅 조정

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant SG as SignupGenre.tsx
  participant RC as react-cookie
  participant API as apiClient
  U->>SG: Next 클릭
  SG->>RC: Authorization 쿠키 조회
  alt 쿠키 있음
    SG->>API: Authorization 헤더 설정
    SG->>API: 이후 가입 진행(요청)
  else 쿠키 없음
    SG->>SG: document.cookie 폴백 파싱
    alt 토큰 발견
      SG->>API: 헤더 설정 후 진행
    else 미발견
      SG-->>U: 토큰 없음 처리(중단/알림)
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • feat: Signup pages #19: 동일 컴포넌트(SignupGenre.tsx)에서 react-cookie 도입과 토큰 추출 흐름 변경과 직접적으로 연관

Suggested labels

✨ Feature

Suggested reviewers

  • ho0010

Poem

간식 같은 쿠키를 살짝 베어물고, 🍪
토큰 냄새 킁킁, 헤더에 살포시 얹고,
서버 문 두드림은 생략하고 폴짝!
로컬 창고에 넣어두고 다시 폴짝!
오늘도 사인업 길, 토끼발로 경쾌하게 뛰어요. 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61ee49b and 55d4ae2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/pages/signup/SignupGenre.tsx (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong merged commit 8338895 into main Aug 12, 2025
1 of 2 checks passed
@vercel

vercel Bot commented Aug 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
thip Ready Preview Comment Aug 12, 2025 0:45am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant