Completely Filter Compiler Attributes from Architecture#305
Merged
alexanderlinne merged 3 commits intomainfrom Oct 11, 2024
Merged
Completely Filter Compiler Attributes from Architecture#305alexanderlinne merged 3 commits intomainfrom
alexanderlinne merged 3 commits intomainfrom
Conversation
Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
alexanderlinne
force-pushed
the
fix/filter-compiler-attributes
branch
from
799055d to
446ddb5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 65.42% 65.43% +0.01%
==========================================
Files 256 256
Lines 22940 22947 +7
Branches 1948 1949 +1
==========================================
+ Hits 15009 15016 +7
Misses 7378 7378
Partials 553 553 ☔ View full report in Codecov by Sentry. |
mak638
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #229. Compiler Attributes are currently filtered in the
ArchBuilderbut are still introduced to the architecture through theAddAttributesAndAttributeDependenciesload task.With this patch, the attributes
Microsoft.CodeAnalysis.EmbeddedAttribute,System.Runtime.CompilerServices.NullableAttributeandSystem.Runtime.CompilerServices.NullableContextAttributewill also be filtered in that load task.