added playerPrefID to the default frontend script#5
Merged
scottf-tvw merged 3 commits intoTVWIT:mainfrom Feb 28, 2025
Merged
Conversation
since we are now handling the rendering with the render.php there’s no longer a reason to used a shared method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update should fix the issue with the player preferences not properly being applied to the player on the front-end.
I also added a new option to the actual player block itself that will allow you to override the player preference per block.
I also cleaned up some code to fall more inline with WP standards.