[BUGFIX] Safety check for foreach#22
Closed
sabbelasichon wants to merge 1 commit into
Closed
Conversation
bmack
reviewed
Apr 22, 2021
| foreach ($this->aliasMap['classNameToAliasMapping'][$originalClassName] as $aliasClassName) { | ||
| if (!$this->classOrInterfaceExists($aliasClassName)) { | ||
| class_alias($originalClassName, $aliasClassName); | ||
| if(is_array($this->aliasMap['classNameToAliasMapping'][$originalClassName])) { |
Member
There was a problem hiding this comment.
one minor remark: Can you add a space between the "if" and the "(" so it is consistent? We badly need some CI checks in this package ;)
Resolves: TYPO3#21
Contributor
|
Could it be that this would be fixed with #20 as well? |
sbuerk
approved these changes
Jul 27, 2022
oliverklee
approved these changes
Jul 27, 2022
lolli42
approved these changes
Aug 1, 2022
Contributor
No is not fixed. The function TYPO3\ClassAliasLoader::loadOriginalClassAndSetAliases($originalClassName) don't use the fixed function TYPO3\ClassAliasLoader::getOriginalClassName($aliasOrClassName). And so the Issue #22 and #21 is not solved! |
This was referenced Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #21