feat(ios): Face ID lock, Connection Info tab, and HIG fixes#1162
Merged
Conversation
…s and editor toolbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mobile P0 HIG sweep — addresses 4 high-priority issues found in the iOS audit:
LAContextwith.deviceOwnerAuthenticationso the system passcode fallback is always available.dynamicTypeSize(...AX1)cap — column type pills, primary key markers, row counts, and index badges no longer break layouts at the largest accessibility sizes. Replaces 7 inline pill copies across 4 views.UIInputView(inputViewStyle: .keyboard)instead of the deprecatedUIScreen.main.bounds.widthmeasurement. The toolbar now self-sizes viaautoresizingMaskand inherits keyboard vibrancy automatically.Plus a few drive-by fixes that surfaced once the type-checker could finish:
RowDetailViewtoolbar share/copy menu extracted to a@ViewBuilderproperty to dodge a Swift type-check timeoutRowDetailViewForEach migrated fromIndexedRow.wrap(rows)(type mismatch on[Row]) torows.indices(length is invariant in this view)ConnectionInfoViewStats section sized correctly by replacingLabeledContent { @ViewBuilder Label }with a flat HStackTest plan
SELECT,FROM, …) and dismiss button; no width clipping in landscape or on iPad split view