refactor(ios): extract data browser logic into DataBrowserViewModel#1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P1 #5 step 1 of 3: lift business logic out of the largest iOS view (
DataBrowserView, 718 LOC) intoDataBrowserViewModel. The View drops down to 452 LOC and now only owns UI state (sheet flags, search input, share text, haptic triggers, navigation flags); the ViewModel owns the data lifecycle.What moves into the ViewModel:
columnDetails,foreignKeys,pagination,sortState,filters,filterLogicMode,activeSearchText,loadError,operationError,isLoading,isPageLoading,memoryWarningload(isInitial:),goToNextPage,goToPreviousPage,goToPage,changePageSize,applySort,applySearch,clearSearch,applyFilters,clearFilters,deleteRow(pkValues:),primaryKeyValues(for:),fetchTotalRows, plus the SQL query construction that was inline in the Viewattach(session:table:databaseType:host:)configures context once on.task. Methods take no contextual argshandleSystemMemoryWarning()collapses the.onReceive(UIApplication.didReceiveMemoryWarningNotification)body into a single VM callWhat stays in the View:
showInsertSheet,showFilterSheet,showShareSheet,showDeleteConfirmation,showStructure,showGoToPage,fkPreviewItem)searchText,goToPageInput,shareText,deleteTarget)hapticSuccess,hapticError)RowDetailViewandInsertRowViewwiringsortColumnBinding,sortDirectionBinding) keep their customBinding(get:set:)shape but read/writeviewModel.sortStateCleanups in the same commit:
Binding<Bool>overviewModel.operationError != nil, removing the parallel@State showOperationErrorand the.onChangeplumbing that kept them in syncrowListGenerationis gone;.id(viewModel.pagination.currentPage)is the natural identity for forcing list reset on page navigationTest plan
ORDER BYWHERE.searchablesubmit and clear — query switches between filtered and fullFKPreviewView