Tier 0 bug fixes, plugin de-duplication and splits, and sync test coverage#1564
Merged
Conversation
…oudflared cleanup
…ers, split oversized drivers
…tabaseType.allCases shim
…lers after API changes
…eLayout file to ThemeFonts
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of correctness fixes and cleanup across the app and plugins, plus new sync test coverage. Every change is build-verified; the new tests compile via
build-for-testingand run in CI (the macOS test target cannot run on this dev machine due to the CodeEdit SwiftLint SPM plugin, so they were verified by compiling + reading).Bug fixes
Info.plistdeclaredTableProPluginKitVersion17 while the app is at 18, so the version gate rejected it. Bumped to 18.DataChangeManager.databaseTypeis now optional with a guard ingenerateSQL, andconfigureForTablerequires an explicit dialect. The deadStructureChangeManager.databaseTypewas removed (DDL comes fromSchemaStatementGenerator(pluginDriver:)).PluginNumericLiteral.isValid).CloudflareTunnelManagerswallowed the stale-PID encode failure withtry?, so leakedcloudflaredprocesses were never cleaned up. Now logged via OSLog.Plugin cleanup
PluginSQLFilter, making the injection-defense escaping a single canonical copy.isNumericColumnTypeintoPluginExportUtilities(was duplicated in the SQL and JSON export plugins).Hygiene
Sequence where Element == UInt8 { hexEncoded }extension.DatabaseType.allCasescompatibility shim; callers useallKnownTypes.AlertHelper) instead of a blocking app-modal alert.ThemeLayout.swifttoThemeFonts.swift(it only heldThemeFonts, no layout).Tests
SyncChangeTrackerTests(dirty/tombstone/suppression/clear, isolated via an injectedSyncMetadataStorage).ConflictResolverTests(queue/FIFO, keep-server returns nil, keep-local copies local fields onto the server record).Notes for reviewers
PluginSQLFilter,PluginNumericLiteral,PluginExportUtilities.isNumericColumnType) are additive public API and ABI-safe, so no PluginKit version bump is needed. The pluginkit-abi check will report an additive diff.PluginStreamElementABI bump,brandColorregistry design, comments-rule and naming policy) is indocs/development/refactor-audit.mdx, intentionally kept out of the docs navigation.