fix(connections): skip password prompt for AWS IAM connections#1566
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 990c787526
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| let password = auth.password | ||
| let promptForPassword = auth.promptForPassword | ||
| let promptForPassword = auth.promptForPassword && !auth.hidesPassword |
There was a problem hiding this comment.
Avoid suppressing non-IAM test password prompts
This now treats every auth mode that hides the password as non-prompting, but auth.hidesPassword is also true for PostgreSQL usePgpass, not just AWS IAM. A normal UI path is to enable “Prompt for password”, then enable “Use ~/.pgpass”; the Test Connection path will stop prompting here and can pass using pgpass, while saving still persists promptForPassword and connectToSession only exempts AWS IAM, so the saved connection prompts anyway. Please gate this on the actual AWS IAM setting or clear/persist the prompt flag consistently for the other hidden-password modes.
Useful? React with 👍 / 👎.
990c787 to
0527c22
Compare
Summary
Changes
!usesAWSIAMin the health-check reconnect path (DatabaseManager+Health) and in session creation (DatabaseManager+Sessions).ConnectionFormCoordinator).Test plan