Skip to content

fix(connections): skip password prompt for AWS IAM connections#1566

Merged
datlechin merged 2 commits into
TableProApp:mainfrom
antoncazalet:iam-auth-password-prompt
Jun 3, 2026
Merged

fix(connections): skip password prompt for AWS IAM connections#1566
datlechin merged 2 commits into
TableProApp:mainfrom
antoncazalet:iam-auth-password-prompt

Conversation

@antoncazalet
Copy link
Copy Markdown
Contributor

Summary

  • AWS IAM connections prompted for a password on connect. IAM supplies the credentials, so the prompt was never needed and only blocked the connection flow.

Changes

  • Gate the password prompt on !usesAWSIAM in the health-check reconnect path (DatabaseManager+Health) and in session creation (DatabaseManager+Sessions).
  • Stop treating IAM connections as prompt-for-password in the connection form (ConnectionFormCoordinator).

Test plan

  • Connect an AWS IAM (RDS) connection and confirm no password prompt appears.
  • Confirm a normal prompt-for-password connection still prompts.
  • Confirm an IAM connection auto-reconnects after a dropped session without prompting.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@antoncazalet
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

github-actions Bot added a commit that referenced this pull request Jun 3, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 990c787526

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


let password = auth.password
let promptForPassword = auth.promptForPassword
let promptForPassword = auth.promptForPassword && !auth.hidesPassword
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid suppressing non-IAM test password prompts

This now treats every auth mode that hides the password as non-prompting, but auth.hidesPassword is also true for PostgreSQL usePgpass, not just AWS IAM. A normal UI path is to enable “Prompt for password”, then enable “Use ~/.pgpass”; the Test Connection path will stop prompting here and can pass using pgpass, while saving still persists promptForPassword and connectToSession only exempts AWS IAM, so the saved connection prompts anyway. Please gate this on the actual AWS IAM setting or clear/persist the prompt flag consistently for the other hidden-password modes.

Useful? React with 👍 / 👎.

@datlechin datlechin force-pushed the iam-auth-password-prompt branch from 990c787 to 0527c22 Compare June 3, 2026 10:40
Copy link
Copy Markdown
Member

@datlechin datlechin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@datlechin datlechin merged commit 635b2d3 into TableProApp:main Jun 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants